Skip to content

Conversation

@NishantJoshi00
Copy link
Contributor

@NishantJoshi00 NishantJoshi00 commented Jun 13, 2023

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Adding logs to request and response of connectors: (stripe, checkout, zen, bluesnap)

The concrete solution is implemented in the following.

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@NishantJoshi00 NishantJoshi00 added A-core Area: Core flows S-waiting-on-review Status: This PR has been implemented and needs to be reviewed A-errors Area: error messages, structure & logging labels Jun 13, 2023
@NishantJoshi00 NishantJoshi00 requested a review from a team as a code owner June 13, 2023 10:40
@NishantJoshi00 NishantJoshi00 self-assigned this Jun 13, 2023
@ArjunKarthik
Copy link
Contributor

@NishantJoshi00 We need to capture the error response as well, logging in get_error_response also required

@ArjunKarthik ArjunKarthik added the S-waiting-on-author Status: This PR is incomplete or needs to address review comments label Jun 13, 2023
Copy link
Contributor

@ArjunKarthik ArjunKarthik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need changes in logging connector request

@NishantJoshi00 NishantJoshi00 removed the S-waiting-on-author Status: This PR is incomplete or needs to address review comments label Jun 14, 2023
@jarnura jarnura added S-ready-for-merge and removed S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Jun 14, 2023
@jarnura jarnura added this pull request to the merge queue Jun 14, 2023
Merged via the queue into main with commit 1e61f39 Jun 14, 2023
@SanchithHegde SanchithHegde deleted the mask-and-log branch June 17, 2023 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-core Area: Core flows A-errors Area: error messages, structure & logging

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants