Add future work section to address potential auth concerns. #338
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Jenkins job istio.github.io/presubmit passed |
lookuptable
reviewed
May 24, 2017
|
|
||
| * Fine-grained authorization and auditing | ||
|
|
||
| * Key and certificate rotation and revocation |
wenchenglu
reviewed
May 24, 2017
|
|
||
| * Fine-grained authorization and auditing | ||
|
|
||
| * Key and certificate rotation and revocation |
There was a problem hiding this comment.
remove this one, since key rotation is already supported, and we may not need revocation with short lived cert
geeknoid
approved these changes
May 24, 2017
wenchenglu
reviewed
May 24, 2017
| * None-http traffic (MySql, Redis, etc.) support | ||
|
|
||
| * Auth information propagation from Envoy to the service | ||
| ([issue](https://github.com/lyft/envoy/issues/794)) |
There was a problem hiding this comment.
remove this line too. we need a design for that on authority delegation as well
myidpt
approved these changes
May 24, 2017
wenchenglu
reviewed
May 24, 2017
|
|
||
| * Inter-cluster service-to-service authentication | ||
|
|
||
| * End-user to service authentication |
There was a problem hiding this comment.
End-user to service authentication using JWT/OAuth2/OpenID_Connect
Member
|
Also can you edit the title of this PR to make it more informational? |
Contributor
|
Jenkins job istio.github.io/presubmit passed |
Contributor
Author
|
@lookuptable , done |
wenchenglu
approved these changes
May 24, 2017
Contributor
|
Jenkins job istio.github.io/presubmit passed |
lookuptable
approved these changes
May 24, 2017
added 2 commits
May 24, 2017 13:48
Contributor
|
Jenkins job istio.github.io/presubmit passed |
Contributor
|
Jenkins job istio.github.io/presubmit passed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add future work section to address potential auth concerns.