Skip to content

Conversation

@SchrodingersGat
Copy link
Member

Ensures that the "default currency" is observed properly in stock forms.

Closes #10625

@SchrodingersGat SchrodingersGat added this to the 1.1.0 milestone Oct 20, 2025
@SchrodingersGat SchrodingersGat added bug Identifies a bug which needs to be addressed pricing Pricing functionality backport Apply this label to a PR to enable auto-backport action User Interface Related to the frontend / User Interface backport-to-1.0.x labels Oct 20, 2025
@netlify
Copy link

netlify bot commented Oct 20, 2025

Deploy Preview for inventree-web-pui-preview canceled.

Name Link
🔨 Latest commit 6c0d502
🔍 Latest deploy log https://app.netlify.com/projects/inventree-web-pui-preview/deploys/68f6ec6d43b68e0009b4b768

@SchrodingersGat SchrodingersGat mentioned this pull request Oct 20, 2025
1 task
- Point currency fields to the correct default method
- Ensure stock item gets correct default currency
@codecov
Copy link

codecov bot commented Oct 20, 2025

Codecov Report

❌ Patch coverage is 95.45455% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 87.83%. Comparing base (6cd733a) to head (6c0d502).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #10641   +/-   ##
=======================================
  Coverage   87.82%   87.83%           
=======================================
  Files        1274     1274           
  Lines       57280    57288    +8     
  Branches     2034     2034           
=======================================
+ Hits        50308    50318   +10     
+ Misses       6472     6470    -2     
  Partials      500      500           
Flag Coverage Δ
backend 89.56% <95.45%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
Backend Apps 91.95% <100.00%> (+<0.01%) ⬆️
Backend General 93.71% <100.00%> (+<0.01%) ⬆️
Frontend 70.08% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@SchrodingersGat SchrodingersGat merged commit f8fd9f5 into inventree:master Oct 21, 2025
34 of 35 checks passed
@SchrodingersGat SchrodingersGat deleted the default-stock-currency branch October 21, 2025 02:43
@github-actions
Copy link
Contributor

💔 All backports failed

Status Branch Result
1.0.x Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

backport --pr 10641

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

SchrodingersGat added a commit to SchrodingersGat/InvenTree that referenced this pull request Oct 21, 2025
* Fix for useStockFields

- Use default currency

* Ensure default currency is observed

* Specify field default

* Improve import (for ty)

* Update migration files

- Point currency fields to the correct default method

* Unit tests

- Ensure stock item gets correct default currency

* Cleaner generation of default currency value

- Return empty string during migratoins

* Update existing migrations

* Reduce noise

* Ignore "no-matching-overload" rule for ty

* Tweak money_kwargs
SchrodingersGat added a commit that referenced this pull request Oct 21, 2025
* Default stock currency (#10641)

* Fix for useStockFields

- Use default currency

* Ensure default currency is observed

* Specify field default

* Improve import (for ty)

* Update migration files

- Point currency fields to the correct default method

* Unit tests

- Ensure stock item gets correct default currency

* Cleaner generation of default currency value

- Return empty string during migratoins

* Update existing migrations

* Reduce noise

* Ignore "no-matching-overload" rule for ty

* Tweak money_kwargs

* Remove conflicting code

* Fix import

* Tweak currency_code_default
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Apply this label to a PR to enable auto-backport action bug Identifies a bug which needs to be addressed pricing Pricing functionality User Interface Related to the frontend / User Interface

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Mixed up currencies

2 participants