[bug] Auto allocate bugfix #10398
Merged
[bug] Auto allocate bugfix #10398
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
SchrodingersGat
commented
Sep 26, 2025
- Fixes bug introduced in Build order consume #8191
- "Consumed" quantity not taken into account for "auto allocation" against build order
- Ensure the already consumed quantity is accounted for
- Ensure that running auto-allocate again does not over-allocate
- Take "consumed" quantity into account also
- build.is_fully_allocated - build.is_overallocated
- Ensure the new calculations work properly
✅ Deploy Preview for inventree-web-pui-preview canceled.
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #10398 +/- ##
=======================================
Coverage 87.43% 87.44%
=======================================
Files 1266 1266
Lines 56644 56682 +38
Branches 2058 2058
=======================================
+ Hits 49528 49565 +37
- Misses 6610 6611 +1
Partials 506 506
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
github-actions bot
pushed a commit
that referenced
this pull request
Sep 27, 2025
* Fix "unallocated_quantity" calculation - Take "consumed" quantity into account also * Account for consumed quantity in: - build.is_fully_allocated - build.is_overallocated * Additional unit tests - Ensure the new calculations work properly * Adjust API filter * Try splitting query * Another fix * Try ExpressionWrapper * Change order of operations? * Refactor * Adjust filtering strategy * Change ordering * Use Max wrapper * Add comments (cherry picked from commit 6fdc6b3)
Contributor
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
SchrodingersGat
added a commit
that referenced
this pull request
Sep 27, 2025
* Fix "unallocated_quantity" calculation - Take "consumed" quantity into account also * Account for consumed quantity in: - build.is_fully_allocated - build.is_overallocated * Additional unit tests - Ensure the new calculations work properly * Adjust API filter * Try splitting query * Another fix * Try ExpressionWrapper * Change order of operations? * Refactor * Adjust filtering strategy * Change ordering * Use Max wrapper * Add comments (cherry picked from commit 6fdc6b3) Co-authored-by: Oliver <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.