Skip to content

feat(backend): add typechecking with ty #9664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
SchrodingersGat merged 52 commits into from
Sep 17, 2025
Merged

feat(backend): add typechecking with ty #9664

SchrodingersGat merged 52 commits into from
Sep 17, 2025

Conversation

@matmair
Copy link
Contributor

@matmair matmair commented May 15, 2025 •
edited
Loading

Adds type checking via astral's (experimental) ty which is pretty fast and seems to perform similar enough to mypy for now.
There is no support for django stubs but is a loooot faster so I think it is worth it.

@netlify
Copy link

netlify bot commented May 15, 2025 •
edited
Loading

✅ Deploy Preview for inventree-web-pui-preview ready!

Name Link
🔨 Latest commit ac36810
🔍 Latest deploy log https://app.netlify.com/projects/inventree-web-pui-preview/deploys/68c9fcd0e707b1000822b7ad
😎 Deploy Preview https://deploy-preview-9664--inventree-web-pui-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 95 (🟢 up 1 from production)
Accessibility: 81 (no change from production)
Best Practices: 100 (no change from production)
SEO: 78 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@codecov
Copy link

codecov bot commented May 15, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 92.50936% with 20 lines in your changes missing coverage. Please review.
✅ Project coverage is 87.35%. Comparing base (a6e5557) to head (ac36810).
⚠️ Report is 314 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #9664      +/-   ##
==========================================
- Coverage   87.39%   87.35%   -0.05%     
==========================================
  Files        1266     1266              
  Lines       56467    56606     +139     
  Branches     2060     2060              
==========================================
+ Hits        49352    49449      +97     
- Misses       6608     6650      +42     
  Partials      507      507
Flag Coverage Δ
backend 89.12% <92.50%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
Backend Apps 91.66% <91.89%> (-0.01%) ⬇️
Backend General 93.66% <100.00%> (+0.01%) ⬆️
Frontend 70.04% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

github-advanced-security[bot]
github-advanced-security bot found potential problems May 15, 2025
View reviewed changes
@matmair matmair modified the milestones: 2.0.0, 1.0.0 Jun 4, 2025
@matmair matmair modified the milestones: 2.0.0, 1.1.0 Jun 19, 2025
@matmair matmair marked this pull request as ready for review September 17, 2025 00:11
@matmair
Copy link
Contributor Author

matmair commented Sep 17, 2025

@SchrodingersGat This is ready for a review and possible merge; I have seen that you also started improving typing hints in the last weeks so I think I do not have to lay out the benefits, especially combined with good IDE tooling.

@SchrodingersGat
Copy link
Member

SchrodingersGat commented Sep 17, 2025

Thanks @matmair these all look like great improvements, well worth the effort!

@SchrodingersGat SchrodingersGat merged commit 21cb488 into inventree:master Sep 17, 2025
48 of 49 checks passed
@SchrodingersGat SchrodingersGat deleted the feat(backend)--Add-typechecking-with-ty branch September 17, 2025 11:30
@wolflu05
Copy link
Member

wolflu05 commented Sep 17, 2025

Is it planned, that ty adds support for Django stubs?

@matmair
Copy link
Contributor Author

matmair commented Sep 17, 2025

One can already install django stubs but there are discussions on the scope of vendored stubs astral-sh/ty#1104

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SchrodingersGat SchrodingersGat SchrodingersGat approved these changes

Assignees

@matmair matmair

Labels

CI CI / unit testing ecosystem

Projects

None yet

Milestone

1.1.0

Development

Successfully merging this pull request may close these issues.

3 participants

@matmair @wolflu05 @SchrodingersGat