fix: properly gate usage of torch.cuda.device_count #3358
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
I think we should remove |
booxter
approved these changes
May 5, 2025
Contributor
booxter
left a comment
There was a problem hiding this comment.
This seems reasonable to unbreak HPU. Ideally, if we have time and will, we eventually implement an abstract device counter that would handle all kinds of accelerators.
s-akhtar-baig
left a comment
There was a problem hiding this comment.
Hey @cdoern! I have added a minor comment, please take a look when you get a chance. Thanks!
since we support HPU and ROCm for inference, we need to gate torch.cuda.device_count since on HPU specificially this will cause issues. use similar logic as we do in `init.py` to ensure CUDA is available, and HPU/ROCm are not. Signed-off-by: Charlie Doern <[email protected]>
Contributor
Author
|
@Mergifyio backport release-v0.26 |
Contributor
✅ Backports have been createdDetails
|
alinaryan
approved these changes
May 5, 2025
jaideepr97
approved these changes
May 5, 2025
6 tasks
mergify bot
added a commit
that referenced
this pull request
May 5, 2025
…3359) since we support HPU and ROCm for inference, we need to gate torch.cuda.device_count since on HPU specificially this will cause issues. use similar logic as we do in `init.py` to ensure CUDA is available, and HPU/ROCm are not. **Checklist:** - [x] **Commit Message Formatting**: Commit titles and messages follow guidelines in the [conventional commits](https://www.conventionalcommits.org/en/v1.0.0/#summary). - [ ] [Changelog](https://github.com/instructlab/instructlab/blob/main/CHANGELOG.md) updated with breaking and/or notable changes for the next minor release. - [ ] Documentation has been updated, if necessary. - [ ] Unit tests have been added, if necessary. - [ ] Functional tests have been added, if necessary. - [ ] E2E Workflow tests have been added, if necessary. <hr>This is an automatic backport of pull request #3358 done by [Mergify](https://mergify.com). Approved-by: booxter Approved-by: cdoern
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
since we support HPU and ROCm for inference, we need to gate torch.cuda.device_count since on HPU specificially this will cause issues.
use similar logic as we do in
init.pyto ensure CUDA is available, and HPU/ROCm are not.Checklist:
conventional commits.