update solid.for for explicit arg types + attempt to fix pip install by pin setuptools/numpy #45
Conversation
f2py compiler on OS-X scans code explicitly for data types of arguments in functions and subroutines. Implicit declarations are not interpreted, causing wheel builds to fail.
|
Thank you @piyushrpt for the Fortran code change! Since the pyproject.toml support in setuptools is introduced in version 61.0 (https://setuptools.pypa.io/en/latest/userguide/pyproject_config.html). I have to bring back a few key configs in setup.py since we are pining If we could not figure out the solution. Merging the fortran change only sounds good to me too. |
|
I'm giving it a last try with explicit |
|
@piyushrpt going to C so we could leverage pybind11 instead of f2py would definitely make this more maintainable long term. |
|
The other option is to disable 3.11+ on osx if this doesn't work |
|
:( The very last thing to try is to set env variable Not sure where it goes. Possibly here: |
let give it a shot
Let's give it a shot. Otherwise "disable 3.11+ on osx" sounds good to me. I do like to convert this to C at some point, would probably have some time next spring for it. You are more than welcome to try it too! |
There was a problem hiding this comment.
Your fix worked (https://github.com/insarlab/PySolid/actions/runs/3402855396)! Thank you @piyushrpt.
f2py compiler for py311+ on OS-X scans code explicitly for data types of arguments in functions and subroutines. Implicit declarations are not interpreted, causing wheel builds to fail. The fortran compiler/ f2py setup on linux seems to be fine with this code and wheels build fine already.
This results in errors such as