Skip to content

fix: type change #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

fix: type change #47

wants to merge 1 commit into from

Conversation

@barely-sad-one
Copy link

@barely-sad-one barely-sad-one commented May 14, 2025 •
edited by sourcery-ai bot
Loading

BUG:
Failed to download grd file. Raised Exception.

REASON:
numpy.int64 was the type of snwe list value which cannot be serialize.

FIX:
To fix it; values are converted into float.

Summary by Sourcery

Bug Fixes:

  • Convert snwe list values to floats before setting the download area to prevent serialization issues with numpy.int64

@barely-sad-one
fix: type change
61436a9 
numpy.int64 was the type of snwe list value which cannot be serialize. To fix it; values are converted into float.
@sourcery-ai
Copy link

sourcery-ai bot commented May 14, 2025 •
edited
Loading

Reviewer's Guide

Converted geographical subset boundaries (snwe) from numpy.int64 to native floats to enable serialization during download.

Sequence Diagram for ECMWFdload Data Download with Corrected Types

sequenceDiagram
    participant Caller
    participant ECMWFdload
    participant CDS_API as "cdsapi.Client"

    Caller->>ECMWFdload: ECMWFdload(snwe=[val1, val2, val3, val4])
    activate ECMWFdload
    ECMWFdload->>ECMWFdload: s, n, w, e = [float(v) for v in snwe]
    ECMWFdload->>ECMWFdload: indict['area'] = [n, w, s, e]
    Note over ECMWFdload: 'area' values are now floats, enabling serialization
    ECMWFdload->>CDS_API: retrieve(dataset, indict)
    activate CDS_API
    Note over CDS_API: indict['area'] successfully serialized due to float types
    CDS_API-->>ECMWFdload: File data / success
    deactivate CDS_API
    ECMWFdload-->>Caller: Download result
    deactivate ECMWFdload
Loading

File-Level Changes

Change Details Files
Convert snwe elements to float for serialization
  • Unpack snwe via a list comprehension that casts each value to float
  • Update area assignment to use the newly cast float values
 src/pyaps3/autoget.py
Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

sourcery-ai[bot]
sourcery-ai bot reviewed May 14, 2025
View reviewed changes
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @barely-sad-one - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good
Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@yunjunz
Copy link
Member

yunjunz commented Jun 3, 2025

This should have been fixed in #45, could you confirm?

@barely-sad-one
Copy link
Author

Thanks @yunjunz . #45 Fixed the issuse.

@yunjunz
Copy link
Member

yunjunz commented Jun 3, 2025

I have just released a new version of 0.3.7, so that the conda user can also get this fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sourcery-ai sourcery-ai[bot] sourcery-ai[bot] left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@barely-sad-one @yunjunz