-
Notifications
You must be signed in to change notification settings - Fork 92
2 fixes #287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2 fixes #287
Conversation
* add some missing translation undefined in the french .ts file * add some translate call * make the tool-tip translatable Not modified : device connections settings (not a good idea to translate that) Maybe run the tool that regenerates the .ts file with new translate entries
Some crappy plotter just cut or lost the last (I dont think more) usb URB block of data. Just shift the real end by adding lots of do nothing bytes. Make var areabase read & write on the config file
|
The areabase fix is fine. I don't think the other one should be included. |
| yield defer.maybeDeferred(connection.write, | ||
| config.commands_after) | ||
|
|
||
| # fix plotter skipping the end of job by sending a lot of 'do nothing' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not something most users will need.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"This is not something most users will need."
as any option existing on a single particular model !
I have checked with wireshark, the data is sent to the plotter, no errors from the PC side 'a priori'.
Sadly, I know no other person using the controller board to see if they have the bug too.
It's a filler sequence of NOP no operation, not needed in 99,9% machines, yes, but I can assure you it fixes end of job not interpreted on my plotter.
Yes I can fill the 'after job sequence' with a thousand of NOP.
But in any case, it is way more easy to deactivate an annoying function than having to remember (or even think) to add it when needed.
Maybe make this another option (turned by default) is a good compromise.
(you can fix areabase independently of this if you want)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe a good compromise would be to add the ability to run a script before and after a job?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that does not solve the problem of the guy when the guy is a user and not 'a researcher' that will find a possible solution here.
Try it with your cutter and see it does not add time nor problem to the job (except a longer debug).
Again, it is easier to enable/disable something existing (you explicitly read it) than guessing you have to add something here for that particular problem when you have it...
I have added some detail here #182 . Those cutter are sold $200 $250, probably a lot of them, sure 0 updates support to expect from the manufacturer.
|
personal note : remember to never update inkcut, USB fix rejected. |
I have cut 4 pieces of 150cm x 60cm
with my 'mod' and did not trash the precious vinyl ;)