Remove from_js_ref and wasm_refgen
#169
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR removes the from_js_ref and wasm_refgen packages from the Keyhive repository, as they have been relocated to a separate repository (https://github.com/automerge/wasm_utils) to make them no_std compatible for use in other projects like Subduction.
Key Changes
- Removed
from_js_refandwasm_refgencrates from the workspace - Updated
keyhive_wasmto depend on external versions of these packages (0.1.3 and 0.1.5 respectively)
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
wasm_refgen/src/lib.rs |
Removed entire procedural macro implementation (225 lines) |
wasm_refgen/README.md |
Removed documentation for the wasm_refgen macro (149 lines) |
wasm_refgen/Cargo.toml |
Removed package manifest for wasm_refgen crate |
from_js_ref/src/lib.rs |
Removed trait definitions for JS reference conversion (28 lines) |
from_js_ref/Cargo.toml |
Removed package manifest for from_js_ref crate |
Cargo.toml |
Removed from_js_ref and wasm_refgen from workspace members |
keyhive_wasm/Cargo.toml |
Updated dependency versions: from_js_ref 0.1.2→0.1.3, wasm_refgen 0.1.4→0.1.5 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I find myself reaching for
wasm_refgenin quite a few places outside of Keyhive. I needed to make itno_stdfor Subduction, so it seemed like a good time to move the non-Keyhive-specific packages to their own repo: https://github.com/automerge/wasm_utils