Skip to content

Conversation

@expede
Copy link
Member

@expede expede commented Apr 19, 2025

@expede expede marked this pull request as ready for review April 21, 2025 21:58
@expede expede requested review from alexjg, ept and pvh as code owners April 21, 2025 21:58
@alexjg alexjg requested a review from jtfmumm as a code owner September 22, 2025 11:11
Copilot AI review requested due to automatic review settings December 6, 2025 00:17
@expede expede force-pushed the rfd-serialization branch from 5a95d3d to 2961abc Compare December 6, 2025 00:17
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR introduces an RFD (Request for Discussion) document that evaluates and selects Protocol Buffers v3 as the serialization format for Keyhive. The PR establishes the RFDs directory structure and documents the technical decision-making process for choosing a secure, efficient serialization format.

  • Creates the RFDs directory with guidelines following RFC 2119 (BCP 14) keyword conventions
  • Documents the serialization format decision (RFD 0002) with comprehensive evaluation of alternatives
  • Updates the spell-checker dictionary with relevant technical terms

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 6 comments.

File Description
rfds/README.md Establishes the RFDs directory with RFC keyword convention guidelines
rfds/0002-serialization/text.md Comprehensive technical document evaluating serialization formats and selecting Protocol Buffers v3
.github/workflows/dictionary.txt Adds technical terms related to serialization formats (Protobuf, CBOR, Avro, etc.) to spell-checker dictionary

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

expede and others added 7 commits December 5, 2025 16:21
Co-authored-by: Copilot <[email protected]>
Signed-off-by: Brooklyn Zelenka <[email protected]>
Co-authored-by: Copilot <[email protected]>
Signed-off-by: Brooklyn Zelenka <[email protected]>
Co-authored-by: Copilot <[email protected]>
Signed-off-by: Brooklyn Zelenka <[email protected]>
Co-authored-by: Copilot <[email protected]>
Signed-off-by: Brooklyn Zelenka <[email protected]>
Co-authored-by: Copilot <[email protected]>
Signed-off-by: Brooklyn Zelenka <[email protected]>
Co-authored-by: Copilot <[email protected]>
Signed-off-by: Brooklyn Zelenka <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants