-
Notifications
You must be signed in to change notification settings - Fork 11
RFD: Serialization #126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
RFD: Serialization #126
Conversation
5a95d3d to
2961abc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR introduces an RFD (Request for Discussion) document that evaluates and selects Protocol Buffers v3 as the serialization format for Keyhive. The PR establishes the RFDs directory structure and documents the technical decision-making process for choosing a secure, efficient serialization format.
- Creates the RFDs directory with guidelines following RFC 2119 (BCP 14) keyword conventions
- Documents the serialization format decision (RFD 0002) with comprehensive evaluation of alternatives
- Updates the spell-checker dictionary with relevant technical terms
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| rfds/README.md | Establishes the RFDs directory with RFC keyword convention guidelines |
| rfds/0002-serialization/text.md | Comprehensive technical document evaluating serialization formats and selecting Protocol Buffers v3 |
| .github/workflows/dictionary.txt | Adds technical terms related to serialization formats (Protobuf, CBOR, Avro, etc.) to spell-checker dictionary |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]> Signed-off-by: Brooklyn Zelenka <[email protected]>
Co-authored-by: Copilot <[email protected]> Signed-off-by: Brooklyn Zelenka <[email protected]>
Co-authored-by: Copilot <[email protected]> Signed-off-by: Brooklyn Zelenka <[email protected]>
Co-authored-by: Copilot <[email protected]> Signed-off-by: Brooklyn Zelenka <[email protected]>
Co-authored-by: Copilot <[email protected]> Signed-off-by: Brooklyn Zelenka <[email protected]>
Co-authored-by: Copilot <[email protected]> Signed-off-by: Brooklyn Zelenka <[email protected]>
📖 Preview