Skip to content

Conversation

@patrickkempff
Copy link
Contributor

Fixes the missing link to the repository when running yarn upgrade-interactive --latest

screen shot 2018-03-07 at 20 42 04

@TravisBuddy
Copy link
Contributor

Travis tests have failed

Hey Patrick Kempff,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

Node.js: node

npm run test:ci
> [email protected] test:ci /home/travis/build/infinitered/solidarity
> jest --ci --runInBand && yarn test:extras

 PASS  __tests__/commands/snapshot.ts
 PASS  __tests__/command_helpers/checkRequirement.ts
 PASS  __tests__/command_helpers/updateRequirement.ts
 PASS  __tests__/command_helpers/reviewRule.ts
 PASS  __tests__/command_helpers/appendSolidaritySettings.ts
 PASS  __tests__/command_helpers/checkShell.ts
 PASS  __tests__/integration/solidarity-check/check-valid.ts (5.178s)
 PASS  __tests__/commands/solidarity.ts
 PASS  __tests__/command_helpers/checkRequirementPlugins.ts
 PASS  __tests__/command_helpers/getSolidaritySettings.ts
 PASS  __tests__/command_helpers/getVersion.ts
 PASS  __tests__/command_helpers/checkCLIForUpdates.ts
 PASS  __tests__/command_helpers/quirksNodeModules.ts
 PASS  __tests__/command_helpers/printResults.ts
 PASS  __tests__/command_helpers/removeNonVersionCharacters.ts
 PASS  __tests__/command_helpers/updateVersions.ts
 PASS  __tests__/commands/create.ts
 PASS  __tests__/integration/solidarity-report/report-basic.ts
 PASS  __tests__/command_helpers/findPluginInfo.ts
 PASS  __tests__/command_helpers/getLineWithVersion.ts
 PASS  __tests__/command_helpers/checkCLI.ts
 PASS  __tests__/command_helpers/skipRule.ts
 PASS  __tests__/extensions/extensionCheck.ts
 PASS  __tests__/index.ts
 PASS  __tests__/commands/help.ts
 PASS  __tests__/integration/solidarity-snapshot/snapshot-nada.ts
 PASS  __tests__/command_helpers/checkENV.ts
 PASS  __tests__/command_helpers/checkDir.ts
 PASS  __tests__/command_helpers/checkFile.ts
 PASS  __tests__/command_helpers/setSolidaritySettings.ts
 PASS  __tests__/integration/solidarity-check/check-invalid.ts
 PASS  __tests__/command_helpers/solidarityReport.ts
 PASS  __tests__/commands/report.ts
 PASS  __tests__/command_helpers/createPlugin.ts
 PASS  __tests__/docs/testDocs.ts
 PASS  __tests__/command_helpers/binaryExists.ts
 PASS  __tests__/schema/validateExampleSchema.ts

Test Suites: 37 passed, 37 total
Tests:       159 passed, 159 total
Snapshots:   44 passed, 44 total
Time:        26.365s
Ran all test suites.
yarn run v1.3.2
$ tslint -p . && yarn madge --extensions ts --circular src/
$ /home/travis/build/infinitered/solidarity/node_modules/.bin/madge --extensions ts --circular src/
=============

WARNING: You are currently running a version of TypeScript which is not officially supported by typescript-eslint-parser.

You may find that it works just fine, or you may not.

SUPPORTED TYPESCRIPT VERSIONS: ~2.6.1

YOUR TYPESCRIPT VERSION: 2.7.2

Please only submit bug reports when using the officially supported version.

=============
⠋ commands/report.ts⠙ extensions/functions/solidarityReport.ts⠹ commands/snapshot.ts⠸ commands/solidarity.ts⠼ extensions/functions/appendSolidaritySettings.ts⠴ extensions/functions/binaryExists.ts⠦ extensions/functions/buildSpecificRequirement.ts⠧ extensions/functions/checkCLI.ts⠇ extensions/functions/checkCLIForUpdates.ts⠏ extensions/functions/checkDir.ts⠋ extensions/functions/checkENV.ts⠙ extensions/functions/checkFile.ts⠹ extensions/functions/checkRequirement.ts⠸ extensions/functions/checkShell.ts⠼ extensions/functions/findPluginInfo.ts⠴ extensions/functions/getLineWithVersion.ts⠦ extensions/functions/getSolidaritySettings.ts⠧ extensions/functions/getVersion.ts⠇ extensions/functions/printResults.ts⠏ extensions/functions/quirksNodeModules.ts⠋ extensions/functions/removeNonVersionCharacters.ts⠙ extensions/functions/reviewRule.ts⠹ extensions/functions/setSolidaritySettings.ts⠸ extensions/functions/updateRequirement.ts⠼ extensions/functions/updateVersions.ts⠴ extensions/solidarity-extension.ts⠦ ./index.tsProcessed 33 files (1.3s) (2 warnings)


Done in 7.11s.

yarn danger ci
yarn run v1.3.2
$ /home/travis/build/infinitered/solidarity/node_modules/.bin/danger ci
You may have updated from Danger 2.x -> 3.x without updating from `danger` to `danger ci`.
The DANGER_GITHUB_API_TOKEN environmental variable is missing
Without an api token, danger will be unable to comment on a PR
Error:  Error: Cannot use authenticated API requests.
    at Object.getPlatformForEnv (/home/travis/build/infinitered/solidarity/node_modules/danger/distribution/platforms/platform.js:16:15)
    at Object.<anonymous> (/home/travis/build/infinitered/solidarity/node_modules/danger/distribution/commands/ci/runner.js:68:70)
    at step (/home/travis/build/infinitered/solidarity/node_modules/danger/distribution/commands/ci/runner.js:32:23)
    at Object.next (/home/travis/build/infinitered/solidarity/node_modules/danger/distribution/commands/ci/runner.js:13:53)
    at fulfilled (/home/travis/build/infinitered/solidarity/node_modules/danger/distribution/commands/ci/runner.js:4:58)
    at <anonymous>
    at process._tickCallback (internal/process/next_tick.js:118:7)
    at Function.Module.runMain (module.js:705:11)
    at startup (bootstrap_node.js:193:16)
    at bootstrap_node.js:660:3
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

Node.js: 8

npm run test:ci
> [email protected] test:ci /home/travis/build/infinitered/solidarity
> jest --ci --runInBand && yarn test:extras

 PASS  __tests__/commands/snapshot.ts
 PASS  __tests__/command_helpers/checkRequirement.ts
 PASS  __tests__/command_helpers/updateRequirement.ts
 PASS  __tests__/command_helpers/reviewRule.ts
 PASS  __tests__/command_helpers/appendSolidaritySettings.ts
 PASS  __tests__/command_helpers/checkShell.ts
 PASS  __tests__/integration/solidarity-check/check-valid.ts (5.159s)
 PASS  __tests__/commands/solidarity.ts
 PASS  __tests__/command_helpers/checkRequirementPlugins.ts
 PASS  __tests__/command_helpers/getSolidaritySettings.ts
 PASS  __tests__/command_helpers/getVersion.ts
 PASS  __tests__/command_helpers/checkCLIForUpdates.ts
 PASS  __tests__/command_helpers/quirksNodeModules.ts
 PASS  __tests__/command_helpers/printResults.ts
 PASS  __tests__/command_helpers/removeNonVersionCharacters.ts
 PASS  __tests__/command_helpers/updateVersions.ts
 PASS  __tests__/commands/create.ts
 PASS  __tests__/integration/solidarity-report/report-basic.ts
 PASS  __tests__/command_helpers/findPluginInfo.ts
 PASS  __tests__/command_helpers/getLineWithVersion.ts
 PASS  __tests__/command_helpers/checkCLI.ts
 PASS  __tests__/command_helpers/skipRule.ts
 PASS  __tests__/extensions/extensionCheck.ts
 PASS  __tests__/index.ts
 PASS  __tests__/commands/help.ts
 PASS  __tests__/integration/solidarity-snapshot/snapshot-nada.ts
 PASS  __tests__/command_helpers/checkENV.ts
 PASS  __tests__/command_helpers/checkDir.ts
 PASS  __tests__/command_helpers/checkFile.ts
 PASS  __tests__/command_helpers/setSolidaritySettings.ts
 PASS  __tests__/integration/solidarity-check/check-invalid.ts
 PASS  __tests__/command_helpers/solidarityReport.ts
 PASS  __tests__/commands/report.ts
 PASS  __tests__/command_helpers/createPlugin.ts
 PASS  __tests__/docs/testDocs.ts
 PASS  __tests__/command_helpers/binaryExists.ts
 PASS  __tests__/schema/validateExampleSchema.ts

Test Suites: 37 passed, 37 total
Tests:       159 passed, 159 total
Snapshots:   44 passed, 44 total
Time:        22.477s
Ran all test suites.
yarn run v1.3.2
$ tslint -p . && yarn madge --extensions ts --circular src/
$ /home/travis/build/infinitered/solidarity/node_modules/.bin/madge --extensions ts --circular src/
=============

WARNING: You are currently running a version of TypeScript which is not officially supported by typescript-eslint-parser.

You may find that it works just fine, or you may not.

SUPPORTED TYPESCRIPT VERSIONS: ~2.6.1

YOUR TYPESCRIPT VERSION: 2.7.2

Please only submit bug reports when using the officially supported version.

=============
⠋ commands/report.ts⠙ extensions/functions/solidarityReport.ts⠹ commands/snapshot.ts⠸ commands/solidarity.ts⠼ extensions/functions/appendSolidaritySettings.ts⠴ extensions/functions/binaryExists.ts⠦ extensions/functions/buildSpecificRequirement.ts⠧ extensions/functions/checkCLI.ts⠇ extensions/functions/checkCLIForUpdates.ts⠏ extensions/functions/checkDir.ts⠋ extensions/functions/checkENV.ts⠙ extensions/functions/checkFile.ts⠹ extensions/functions/checkRequirement.ts⠸ extensions/functions/checkShell.ts⠼ extensions/functions/findPluginInfo.ts⠴ extensions/functions/getLineWithVersion.ts⠦ extensions/functions/getSolidaritySettings.ts⠧ extensions/functions/getVersion.ts⠇ extensions/functions/printResults.ts⠏ extensions/functions/quirksNodeModules.ts⠋ extensions/functions/removeNonVersionCharacters.ts⠙ extensions/functions/reviewRule.ts⠹ extensions/functions/setSolidaritySettings.ts⠸ extensions/functions/updateRequirement.ts⠼ extensions/functions/updateVersions.ts⠴ extensions/solidarity-extension.ts⠦ ./index.tsProcessed 33 files (1.2s) (2 warnings)


Done in 5.59s.

yarn danger ci
yarn run v1.3.2
$ /home/travis/build/infinitered/solidarity/node_modules/.bin/danger ci
You may have updated from Danger 2.x -> 3.x without updating from `danger` to `danger ci`.
The DANGER_GITHUB_API_TOKEN environmental variable is missing
Without an api token, danger will be unable to comment on a PR
Error:  Error: Cannot use authenticated API requests.
    at Object.getPlatformForEnv (/home/travis/build/infinitered/solidarity/node_modules/danger/distribution/platforms/platform.js:16:15)
    at Object.<anonymous> (/home/travis/build/infinitered/solidarity/node_modules/danger/distribution/commands/ci/runner.js:68:70)
    at step (/home/travis/build/infinitered/solidarity/node_modules/danger/distribution/commands/ci/runner.js:32:23)
    at Object.next (/home/travis/build/infinitered/solidarity/node_modules/danger/distribution/commands/ci/runner.js:13:53)
    at fulfilled (/home/travis/build/infinitered/solidarity/node_modules/danger/distribution/commands/ci/runner.js:4:58)
    at <anonymous>
    at process._tickCallback (internal/process/next_tick.js:188:7)
    at Function.Module.runMain (module.js:695:11)
    at startup (bootstrap_node.js:188:16)
    at bootstrap_node.js:609:3
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

@patrickkempff
Copy link
Contributor Author

patrickkempff commented Mar 7, 2018

@GantMan The failing Travis-ci build has nothing to do with this change:

Error:  Error: Cannot use authenticated API requests.

@GantMan
Copy link
Member

GantMan commented Mar 7, 2018

restarted the Travis CI

@TravisBuddy
Copy link
Contributor

Travis tests have failed

Hey Patrick Kempff,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

Node.js: node

npm run test:ci
> [email protected] test:ci /home/travis/build/infinitered/solidarity
> jest --ci --runInBand && yarn test:extras

 PASS  __tests__/commands/snapshot.ts (29.016s)
 PASS  __tests__/command_helpers/checkRequirement.ts
 PASS  __tests__/command_helpers/updateRequirement.ts
 PASS  __tests__/command_helpers/reviewRule.ts
 PASS  __tests__/command_helpers/appendSolidaritySettings.ts
 PASS  __tests__/command_helpers/checkShell.ts
 PASS  __tests__/integration/solidarity-check/check-valid.ts (6.423s)
 PASS  __tests__/commands/solidarity.ts
 PASS  __tests__/command_helpers/checkRequirementPlugins.ts
 PASS  __tests__/command_helpers/getSolidaritySettings.ts
 PASS  __tests__/command_helpers/getVersion.ts
 PASS  __tests__/command_helpers/checkCLIForUpdates.ts
 PASS  __tests__/command_helpers/quirksNodeModules.ts
 PASS  __tests__/command_helpers/printResults.ts
 PASS  __tests__/command_helpers/removeNonVersionCharacters.ts
 PASS  __tests__/command_helpers/updateVersions.ts
 PASS  __tests__/commands/create.ts
 PASS  __tests__/integration/solidarity-report/report-basic.ts
 PASS  __tests__/command_helpers/findPluginInfo.ts
 PASS  __tests__/command_helpers/getLineWithVersion.ts
 PASS  __tests__/command_helpers/checkCLI.ts
 PASS  __tests__/command_helpers/skipRule.ts
 PASS  __tests__/extensions/extensionCheck.ts
 PASS  __tests__/index.ts
 PASS  __tests__/commands/help.ts
 PASS  __tests__/integration/solidarity-snapshot/snapshot-nada.ts
 PASS  __tests__/command_helpers/checkENV.ts
 PASS  __tests__/command_helpers/checkDir.ts
 PASS  __tests__/command_helpers/checkFile.ts
 PASS  __tests__/command_helpers/setSolidaritySettings.ts
 PASS  __tests__/integration/solidarity-check/check-invalid.ts
 PASS  __tests__/command_helpers/solidarityReport.ts
 PASS  __tests__/commands/report.ts
 PASS  __tests__/command_helpers/createPlugin.ts
 PASS  __tests__/docs/testDocs.ts
 PASS  __tests__/command_helpers/binaryExists.ts
 PASS  __tests__/schema/validateExampleSchema.ts

Test Suites: 37 passed, 37 total
Tests:       159 passed, 159 total
Snapshots:   44 passed, 44 total
Time:        59.187s
Ran all test suites.
yarn run v1.3.2
$ tslint -p . && yarn madge --extensions ts --circular src/
$ /home/travis/build/infinitered/solidarity/node_modules/.bin/madge --extensions ts --circular src/
=============

WARNING: You are currently running a version of TypeScript which is not officially supported by typescript-eslint-parser.

You may find that it works just fine, or you may not.

SUPPORTED TYPESCRIPT VERSIONS: ~2.6.1

YOUR TYPESCRIPT VERSION: 2.7.2

Please only submit bug reports when using the officially supported version.

=============
⠋ commands/report.ts⠙ extensions/functions/solidarityReport.ts⠹ commands/snapshot.ts⠸ commands/solidarity.ts⠼ extensions/functions/appendSolidaritySettings.ts⠴ extensions/functions/binaryExists.ts⠦ extensions/functions/buildSpecificRequirement.ts⠧ extensions/functions/checkCLI.ts⠇ extensions/functions/checkCLIForUpdates.ts⠏ extensions/functions/checkDir.ts⠋ extensions/functions/checkENV.ts⠙ extensions/functions/checkFile.ts⠹ extensions/functions/checkRequirement.ts⠸ extensions/functions/checkShell.ts⠼ extensions/functions/findPluginInfo.ts⠴ extensions/functions/getLineWithVersion.ts⠦ extensions/functions/getSolidaritySettings.ts⠧ extensions/functions/getVersion.ts⠇ extensions/functions/printResults.ts⠏ extensions/functions/quirksNodeModules.ts⠋ extensions/functions/removeNonVersionCharacters.ts⠙ extensions/functions/reviewRule.ts⠹ extensions/functions/setSolidaritySettings.ts⠸ extensions/functions/updateRequirement.ts⠼ extensions/functions/updateVersions.ts⠴ extensions/solidarity-extension.ts⠦ ./index.tsProcessed 33 files (1.6s) (2 warnings)


Done in 7.47s.

yarn danger ci
The DANGER_GITHUB_API_TOKEN environmental variable is missing
Without an api token, danger will be unable to comment on a PR
Error:  Error: Cannot use authenticated API requests.
    at Object.getPlatformForEnv (/home/travis/build/infinitered/solidarity/node_modules/danger/distribution/platforms/platform.js:16:15)
    at Object.<anonymous> (/home/travis/build/infinitered/solidarity/node_modules/danger/distribution/commands/ci/runner.js:68:70)
    at step (/home/travis/build/infinitered/solidarity/node_modules/danger/distribution/commands/ci/runner.js:32:23)
    at Object.next (/home/travis/build/infinitered/solidarity/node_modules/danger/distribution/commands/ci/runner.js:13:53)
    at fulfilled (/home/travis/build/infinitered/solidarity/node_modules/danger/distribution/commands/ci/runner.js:4:58)
    at <anonymous>
    at process._tickCallback (internal/process/next_tick.js:118:7)
    at Function.Module.runMain (module.js:705:11)
    at startup (bootstrap_node.js:193:16)
    at bootstrap_node.js:660:3
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

Node.js: 8

npm run test:ci
> [email protected] test:ci /home/travis/build/infinitered/solidarity
> jest --ci --runInBand && yarn test:extras

 PASS  __tests__/commands/snapshot.ts
 PASS  __tests__/command_helpers/checkRequirement.ts
 PASS  __tests__/command_helpers/updateRequirement.ts
 PASS  __tests__/command_helpers/reviewRule.ts
 PASS  __tests__/command_helpers/appendSolidaritySettings.ts
 PASS  __tests__/command_helpers/checkShell.ts
 PASS  __tests__/integration/solidarity-check/check-valid.ts (5.159s)
 PASS  __tests__/commands/solidarity.ts
 PASS  __tests__/command_helpers/checkRequirementPlugins.ts
 PASS  __tests__/command_helpers/getSolidaritySettings.ts
 PASS  __tests__/command_helpers/getVersion.ts
 PASS  __tests__/command_helpers/checkCLIForUpdates.ts
 PASS  __tests__/command_helpers/quirksNodeModules.ts
 PASS  __tests__/command_helpers/printResults.ts
 PASS  __tests__/command_helpers/removeNonVersionCharacters.ts
 PASS  __tests__/command_helpers/updateVersions.ts
 PASS  __tests__/commands/create.ts
 PASS  __tests__/integration/solidarity-report/report-basic.ts
 PASS  __tests__/command_helpers/findPluginInfo.ts
 PASS  __tests__/command_helpers/getLineWithVersion.ts
 PASS  __tests__/command_helpers/checkCLI.ts
 PASS  __tests__/command_helpers/skipRule.ts
 PASS  __tests__/extensions/extensionCheck.ts
 PASS  __tests__/index.ts
 PASS  __tests__/commands/help.ts
 PASS  __tests__/integration/solidarity-snapshot/snapshot-nada.ts
 PASS  __tests__/command_helpers/checkENV.ts
 PASS  __tests__/command_helpers/checkDir.ts
 PASS  __tests__/command_helpers/checkFile.ts
 PASS  __tests__/command_helpers/setSolidaritySettings.ts
 PASS  __tests__/integration/solidarity-check/check-invalid.ts
 PASS  __tests__/command_helpers/solidarityReport.ts
 PASS  __tests__/commands/report.ts
 PASS  __tests__/command_helpers/createPlugin.ts
 PASS  __tests__/docs/testDocs.ts
 PASS  __tests__/command_helpers/binaryExists.ts
 PASS  __tests__/schema/validateExampleSchema.ts

Test Suites: 37 passed, 37 total
Tests:       159 passed, 159 total
Snapshots:   44 passed, 44 total
Time:        22.477s
Ran all test suites.
yarn run v1.3.2
$ tslint -p . && yarn madge --extensions ts --circular src/
$ /home/travis/build/infinitered/solidarity/node_modules/.bin/madge --extensions ts --circular src/
=============

WARNING: You are currently running a version of TypeScript which is not officially supported by typescript-eslint-parser.

You may find that it works just fine, or you may not.

SUPPORTED TYPESCRIPT VERSIONS: ~2.6.1

YOUR TYPESCRIPT VERSION: 2.7.2

Please only submit bug reports when using the officially supported version.

=============
⠋ commands/report.ts⠙ extensions/functions/solidarityReport.ts⠹ commands/snapshot.ts⠸ commands/solidarity.ts⠼ extensions/functions/appendSolidaritySettings.ts⠴ extensions/functions/binaryExists.ts⠦ extensions/functions/buildSpecificRequirement.ts⠧ extensions/functions/checkCLI.ts⠇ extensions/functions/checkCLIForUpdates.ts⠏ extensions/functions/checkDir.ts⠋ extensions/functions/checkENV.ts⠙ extensions/functions/checkFile.ts⠹ extensions/functions/checkRequirement.ts⠸ extensions/functions/checkShell.ts⠼ extensions/functions/findPluginInfo.ts⠴ extensions/functions/getLineWithVersion.ts⠦ extensions/functions/getSolidaritySettings.ts⠧ extensions/functions/getVersion.ts⠇ extensions/functions/printResults.ts⠏ extensions/functions/quirksNodeModules.ts⠋ extensions/functions/removeNonVersionCharacters.ts⠙ extensions/functions/reviewRule.ts⠹ extensions/functions/setSolidaritySettings.ts⠸ extensions/functions/updateRequirement.ts⠼ extensions/functions/updateVersions.ts⠴ extensions/solidarity-extension.ts⠦ ./index.tsProcessed 33 files (1.2s) (2 warnings)


Done in 5.59s.

travis_time:end:008066e4:start=1520452018053478752,finish=1520452047449634053,duration=29396155301

yarn danger ci
yarn run v1.3.2
$ /home/travis/build/infinitered/solidarity/node_modules/.bin/danger ci
You may have updated from Danger 2.x -> 3.x without updating from `danger` to `danger ci`.
The DANGER_GITHUB_API_TOKEN environmental variable is missing
Without an api token, danger will be unable to comment on a PR
Error:  Error: Cannot use authenticated API requests.
    at Object.getPlatformForEnv (/home/travis/build/infinitered/solidarity/node_modules/danger/distribution/platforms/platform.js:16:15)
    at Object.<anonymous> (/home/travis/build/infinitered/solidarity/node_modules/danger/distribution/commands/ci/runner.js:68:70)
    at step (/home/travis/build/infinitered/solidarity/node_modules/danger/distribution/commands/ci/runner.js:32:23)
    at Object.next (/home/travis/build/infinitered/solidarity/node_modules/danger/distribution/commands/ci/runner.js:13:53)
    at fulfilled (/home/travis/build/infinitered/solidarity/node_modules/danger/distribution/commands/ci/runner.js:4:58)
    at <anonymous>
    at process._tickCallback (internal/process/next_tick.js:188:7)
    at Function.Module.runMain (module.js:695:11)
    at startup (bootstrap_node.js:188:16)
    at bootstrap_node.js:609:3
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

travis_time:end:31cb1dcc:start=1520452047456335082,finish=1520452048360314919,duration=903979837

@GantMan GantMan merged commit ce7b1e6 into infinitered:master Mar 7, 2018
@GantMan
Copy link
Member

GantMan commented Mar 7, 2018

thanks so much @patrickkempff

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants