Skip to content

fix 'optimize' and 'alter index' #3036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Oct 22, 2025
Merged

fix 'optimize' and 'alter index' #3036

merged 8 commits into from
Oct 22, 2025

Conversation

@zpf121
Copy link
Contributor

@zpf121 zpf121 commented Oct 21, 2025 •
edited
Loading

Summary

This PR replaces OPTIMIZE IDENTIFIER syntax with ALTER IDENTIFIER to better align with SQL standards

Changes

  • Modified corresponding grammar rules in the parser
  • Modified corresponding logical and physical operators
  • Modified corresponding test code

@zpf121 zpf121 added the ci PR can be test label Oct 21, 2025
@JinHai-CN JinHai-CN marked this pull request as ready for review October 21, 2025 09:15
@yuzhichang yuzhichang force-pushed the main branch 2 times, most recently from 5e09fdf to 9881286 Compare October 21, 2025 10:06
@codecov
Copy link

codecov bot commented Oct 21, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 68.42105% with 18 lines in your changes missing coverage. Please review.
✅ Project coverage is 46.72%. Comparing base (ad4c2fc) to head (f8e56bc).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/executor/operator/physical_alter_impl.cpp 53.84% 9 Missing and 3 partials ⚠️
src/planner/node/logical_alter_impl.cpp 0.00% 4 Missing ⚠️
src/executor/physical_planner_impl.cpp 90.00% 1 Missing ⚠️
src/main/query_context_impl.cpp 75.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3036      +/-   ##
==========================================
+ Coverage   46.68%   46.72%   +0.04%     
==========================================
  Files         724      724              
  Lines      193658   194030     +372     
  Branches    27275    27277       +2     
==========================================
+ Hits        90402    90661     +259     
- Misses      93688    93817     +129     
+ Partials     9568     9552      -16
Flag Coverage Δ
debug http test 27.83% <5.26%> (-0.27%) ⬇️
debug parallel test 18.14% <0.00%> (-0.02%) ⬇️
debug pysdk test 29.72% <5.26%> (+<0.01%) ⬆️
debug sqllogical test 32.23% <64.91%> (+0.05%) ⬆️
debug unit test 30.27% <63.15%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@zpf121 zpf121 force-pushed the fix_optimize_and_alter_index branch from e87cd49 to 130ba52 Compare October 21, 2025 10:53
@zpf121 zpf121 added ci PR can be test and removed ci PR can be test labels Oct 21, 2025
@JinHai-CN JinHai-CN added ci PR can be test and removed ci PR can be test labels Oct 21, 2025
@zpf121 zpf121 added ci PR can be test and removed ci PR can be test labels Oct 22, 2025
@zpf121 zpf121 added ci PR can be test and removed ci PR can be test labels Oct 22, 2025
@JinHai-CN JinHai-CN merged commit d3724f7 into infiniflow:main Oct 22, 2025
28 checks passed
@zpf121 zpf121 deleted the fix_optimize_and_alter_index branch October 22, 2025 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

ci PR can be test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@zpf121 @JinHai-CN