Skip to content

Conversation

@qinling0210
Copy link
Contributor

@qinling0210 qinling0210 commented May 13, 2025

What problem does this PR solve?

  1. Add more TxnStore definition in base_txn_store.cppm
  2. Put data into TxnStore for multiple operations.
  3. Check Conflict using TxnStore (functions CheckConflictTxnStore() in new_txn.cpp)

TestUpdate failed because it intends to store 2 txn stores(Append and Delete), we will keep the functions of new conflict check, but use old conflict functions currently. After implementing NewTxxn::Update and update txn store, will will enable the new conflict check function.

Type of change

  • Refactoring

@qinling0210 qinling0210 requested a review from JinHai-CN May 13, 2025 04:08
@qinling0210 qinling0210 self-assigned this May 13, 2025
@qinling0210 qinling0210 requested a review from JinHai-CN May 13, 2025 06:27
@qinling0210 qinling0210 force-pushed the refactor_conflict_check branch from 4dd3474 to 545793f Compare May 13, 2025 12:39
@qinling0210 qinling0210 added the ci PR can be test label May 13, 2025
@JinHai-CN JinHai-CN merged commit def06e4 into infiniflow:main May 13, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci PR can be test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants