mypy: fix errors from stricter cgen typing #899
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexfikl
commented
Jan 8, 2025
Comment on lines
+842
to
846
| assert isinstance(function_decl, FunctionDeclarationWrapper) | ||
| if not isinstance(function_body, Block): | ||
| function_body = Block([function_body]) | ||
|
|
||
| fbody = FunctionBody(function_decl, function_body) |
Contributor
Author
There was a problem hiding this comment.
This if could be in cgen, but the current docs say that FunctionBody takes a block:
https://github.com/inducer/cgen/blob/738bdb6ea330de63dc1e476025b8ca693b535443/cgen/__init__.py#L992-L1006
8b488b6 to
e6523c7
Compare
alexfikl
commented
Jan 8, 2025
|
|
||
| if tv.initializer is not None: | ||
| decl = Initializer(decl, generate_array_literal( | ||
| init_decl = Initializer(decl, generate_array_literal( |
Contributor
Author
There was a problem hiding this comment.
This is necessary because Initializer takes a Declarator, not a Generable (like the forced annotation above).
Owner
|
LGTM, thx! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added some more typing to cgen during the break that caused some errors in loopy. This preemptively fixes them :D