Skip to content

Fix check for redundant loop priority #895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
inducer merged 3 commits into from
Dec 4, 2024
Merged

Fix check for redundant loop priority #895

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d35f9f9
Test loop prioties with v2 scheduler
kaushikcfd Dec 4, 2024
32e1ba3
Correct the check to see if loop priority is redundant
kaushikcfd Dec 4, 2024
ffe77c3
Enable F841 unused-variable lint, fix
inducer Dec 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Test loop prioties with v2 scheduler 
Co-authored-by: Connor Ward <[email protected]>
  • Loading branch information
@kaushikcfd @connorjward
kaushikcfd and connorjward committed Dec 4, 2024
commit d35f9f9130b919bb0923fd5baf9df14de14997c8
15 changes: 15 additions & 0 deletions test/test_loopy.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3704,6 +3704,21 @@ def test_long_kernel():
lp.get_one_linearized_kernel(t_unit.default_entrypoint, t_unit.callables_table)


@pytest.mark.filterwarnings("error:.*:loopy.LoopyWarning")
def test_loop_imperfect_nest_priorities_in_v2_scheduler():
# Reported by Connor Ward. See <https://github.com/inducer/loopy/issues/890>.
knl = lp.make_kernel(
"{ [i,j,k]: 0 <= i,j,k < 5}",
"""
x[i, j] = i + j
y[i, k] = i + k
""",
loop_priority=frozenset({("i", "j"), ("i", "k")}),
)

code = lp.generate_code_v2(knl)


if __name__ == "__main__":
if len(sys.argv) > 1:
exec(sys.argv[1])
Expand Down