Add feature to allow disabling reconnection. #203
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kinyoklion
commented
Aug 6, 2025
kinyoklion
commented
Aug 6, 2025
|
Not sure about this handling in |
elbrujohalcon
requested changes
Aug 7, 2025
I will take a stab at it. |
|
@elbrujohalcon Addressed feedback and added tests. |
elbrujohalcon
approved these changes
Aug 8, 2025
|
Thanks, @kinyoklion ! You've got a new release now: https://hex.pm/packages/shotgun/1.2.1 |
kinyoklion
added a commit
to launchdarkly/erlang-server-sdk
that referenced
this pull request
Aug 8, 2025
BEGIN_COMMIT_OVERRIDE feat: Update minimum OTP version to 24. fix: Fix issue where sometimes a dropped stream would not reconnect. END_COMMIT_OVERRIDE In shotgun 1.1.0 a new feature was introduced which introduced a bug with the SSE connection. Where previously it would close its process in all cases where it disconnected, now it would not do that in some situations. This caused #155. We contributed an update to shotgun to allow disabling the feature for async connections where you need to monitor the connection state. inaka/shotgun#203 This was released in shotgun 1.2.1. This PR updates to 1.2.1 and uses the option to disable the `reopen` feature added in shotgun 1.1.0. This PR also raises the minimum erlang version to 24. This is required to gun 2.2 which shotgun 1.2.0 and newer depends on. OTP doesn't have an official support timeline, but OTP 24 came out in 2021, so most people will likely be on 24 or greater especially when using elixir.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an option that allows for reconnects to be disabled when doing an async
getrequest. Currently I only added this option to the async path as I am unsure of how the reconnect feature is intended to be used.I've tried this approach with the LaunchDarkly SDK and it resolved the issue we were encountering with the reconnect feature #202.
Original issue: launchdarkly/erlang-server-sdk#155