Skip to content

Additional changes for gun 2.0 #195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 20, 2023
Merged

Additional changes for gun 2.0 #195

merged 3 commits into from
Jul 20, 2023

Conversation

@kinyoklion
Copy link
Contributor

@kinyoklion kinyoklion commented Jul 18, 2023 •
edited
Loading

In the original PR for updating to gun 2.0.0 there were a couple missed things that were causing issues.

1.) The typing for the open method was not updated from transport_opts to have tcp_opts and tls_opts. (Though likely it could also remove them and just require gun options.)
2.) The lockfile was not updated, which resulted in rebar3 installing gun 1.3.1 instead of 2.

I also went ahead and updated to 2.0.1.

@kinyoklion kinyoklion changed the title Changes for gun 2.0 Additional changes for gun 2.0 Jul 18, 2023
@kinyoklion
Copy link
Contributor Author

Hello @phunehehe, potentially we could coordinate to sort what updates may be needed for a release.

The unit tests seem to be in a non-functional state as well.

@phunehehe
Copy link
Collaborator

Hi @kinyoklion for context I'm coming here from Elixir and I'm not very familiar with Erlang
You probably found something that I'm not using. The change looks good AFAIK and I have approved it. Will wait a bit and if nobody chimes in I'll merge and tag a release because why not
Feel free to improve the tests if you can
Thanks

@kinyoklion
Copy link
Contributor Author

kinyoklion commented Jul 18, 2023 •
edited
Loading

Thank you @phunehehe,

Do you know if you will be able to publish to hex.pm?

I may take a look at those tests later and see if they can easily be made functional.

Thanks,
Ryan

@phunehehe
Copy link
Collaborator

hmm I don't have access to hex.pm
@elbrujohalcon is this something you can give out? :)

@elbrujohalcon
Copy link
Member

@phunehehe yeah, I can add you as an owner for the project in hex.pm. Just give me your hex.pm username.

@phunehehe
Copy link
Collaborator

@elbrujohalcon I just made an account on hex.pm, my username is phunehehe

@elbrujohalcon
Copy link
Member

You should be allowed to publish releases now, @phunehehe

@elbrujohalcon
Copy link
Member

Yo do appear in the list of owners in https://hex.pm/packages/shotgun

@phunehehe phunehehe merged commit f004f5c into inaka:master Jul 20, 2023
@phunehehe
Copy link
Collaborator

image
how about that!

@kinyoklion
Copy link
Contributor Author

Thank you @phunehehe and @elbrujohalcon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@phunehehe phunehehe phunehehe approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kinyoklion @phunehehe @elbrujohalcon