fix(giscus): theme and language #783
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for hugo-hextra ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
1257862 to
74a5f85
Compare
74a5f85 to
c0f4a4f
Compare
20b9a55 to
d4a94b0
Compare
|
Sorry, I added several commits after opening the PR because I found other bugs. |
imfing
reviewed
Aug 24, 2025
| } | ||
| }); | ||
| </script> | ||
|
|
||
| <div id="giscus"></div> | ||
| <div id="giscus-hextra-bb112b9f807c37c1752e5da6a1652a29"></div> |
There was a problem hiding this comment.
This is a random hash to be sure to have a unique ID.
Currently, without my PR, if you enable Giscuss and go to the page http://localhost:1313/docs/advanced/comments/ you will see the problem.
The problem happens because the page contains 2 elements with the id giscuss: a title inside the page and the Giscuss div at the bottom of the page.
There was a problem hiding this comment.
I see, thanks for the explanation. Might worth adding a line of comment.
imfing
reviewed
Aug 24, 2025
imfing
approved these changes
Aug 24, 2025
imfing
reviewed
Aug 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
systemthemedocs/advanced/comments/Closes #358