Merge from upstream: 7 commits, 6 files changed #335
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| "python-magic-bin>=0.4.0,<0.5.0;sys_platform=='win32'", | ||
| "flask-httpAuth>=4.4.0,<5.0.0", | ||
| "cryptography>=39.0.0,<45.0.0", | ||
| "certifi>=2024.7.4,<2025.8.24", |
There was a problem hiding this comment.
seems like an explanation would be useful here
| config.config_use_goodreads) | ||
|
|
||
| # Google Books API configuration | ||
| reboot_required |=_config_string(to_save, "config_googlebooks_api_key") |
There was a problem hiding this comment.
seems odd that setting config makes reboot required
|
Thanks @chapmanjacobd for looking this over: @deldesir @Akatama I'll should probably go ahead and merge this today, if it looks good enough / safe enough, and you have no objections (: |
|
Other than the things Jacob mentioned, I don't see anything else that is concerning. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@chapmanjacobd @deldesir @Akatama does this look reasonably safe to merge quickly?
🙏