Skip to content

Refactor metadata_extract.py #257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Refactor metadata_extract.py #257

wants to merge 5 commits into from

Conversation

@deldesir
Copy link
Collaborator

@deldesir deldesir commented Sep 24, 2024 •
edited
Loading

This pull request refactors the metadata_extract.py file to improve code readability, maintainability, and performance.

Key Changes Introduced:

  • Replaced direct SQLite queries with SQLAlchemy ORM for database interactions.

  • Enhanced logging for better traceability and debugging within the task class.

  • Improved error handling to manage exceptions more gracefully.

  • Refactored the subprocess execution and metadata updating logic.

  • Tested on Ubuntu 24.04

@deldesir
Refactor metadata_extract.py
45e4323 
Uses SQLAlchemy...
@deldesir deldesir marked this pull request as draft September 24, 2024 17:00
@deldesir deldesir requested a review from holta September 25, 2024 02:18
@deldesir deldesir self-assigned this Sep 25, 2024
@deldesir deldesir added the enhancement New feature or request label Sep 25, 2024
@deldesir deldesir marked this pull request as ready for review September 25, 2024 02:18
@holta
Copy link
Member

holta commented Sep 25, 2024

How was this tested?

Thanks @deldesir!

@holta holta mentioned this pull request Sep 25, 2024
Closed
@deldesir
Optimize duration variable and fix TaskDownload call
869789c 
Optimization: Removes the for loop for total_duration specifically and incorporated the var into the subsequent for loop. 
Fixes TaskDownload call where session was being passed wrongly.
Cleans up live_status variable.
@deldesir
Copy link
Collaborator Author

How to test

  • Pull the PR following How do I test a pull request (PR) ? instructions.
  • Submit a YouTube video URL via the “Download to IIAB” button and monitor the “Task” page to check whether metadata fetching is reported.
  • On success, verify with datasette to review the extraction with datasette /library/calibre-web/xklb-metadata.db -h 0.0.0.0 -p <PORT_NUMBER> and then point your browser to http:<IIAB_URL>:<PORT_NUMBER>. If metadata are present for the required video, that means the refactoring was effective and functionality is preserved.

This was referenced Oct 19, 2024
Open
Closed
@deldesir deldesir mentioned this pull request Nov 6, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@holta holta Awaiting requested review from holta

Assignees

@deldesir deldesir

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@deldesir @holta