Skip to content

Make covers square #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 24, 2023
Merged

Make covers square #2

merged 1 commit into from
Oct 24, 2023

Conversation

deldesir
Copy link
Collaborator

Set fixed width and weight to the cover container and adjust the margin of the last book in a row.

@deldesir
Make covers square
f69b444 
Set fixed width and weight to the cover container and adjust the margin of the last book in a row.
@deldesir deldesir added the enhancement New feature or request label Sep 15, 2023
@deldesir deldesir requested a review from holta September 15, 2023 16:30
@deldesir deldesir self-assigned this Sep 15, 2023
holta
holta approved these changes Sep 15, 2023
View reviewed changes
Copy link
Member

@holta holta left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that max-width: 180px; and height: 225px; are both shrinking to 150x — which might be a bit small on some tablets?

But if this is tested well enough, Good Enough for Now!

(This will surely evolved over time... as UX requirements become more clear!)

holta
holta approved these changes Sep 15, 2023
View reviewed changes
Copy link
Member

@holta holta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that max-width: 180px; and height: 225px; are both shrinking to 150x — which might be a bit small on some tablets?

@deldesir Can you post a quick explanation to https://github.com/iiab/calibre-web/wiki (or on this ticket is fine too) explaining your thinking here? So that our choices are more clear when this eventually has to evolve sometime in coming months?

As long as there is some/minimal public documentation explaining this "evolving reasoning" in Plain English... then this PR should definitely be good enough to merge!

@deldesir
Copy link
Collaborator Author

The use of square covers is a deliberate decision to improve aesthetics, proving to be a more efficient use of space [in my opinion], whether in the Calibre-web interface or on the screens of various devices.

deldesir added a commit that referenced this pull request Sep 26, 2023
@deldesir
Merge pull request #2 from deldesir/video
d05cd50 
Video
@holta holta merged commit 5a4dad2 into master Oct 24, 2023
deldesir added a commit that referenced this pull request Nov 29, 2023
@deldesir
Merge pull request #2 from deldesir/deldesir-patch-4
9532fa5 
Pin max format
@deldesir deldesir deleted the deldesir-square-cover branch December 5, 2023 15:40
This was referenced Dec 18, 2023
Merged
Open
Merged
@holta holta mentioned this pull request Dec 28, 2023
Merged
@Akatama Akatama mentioned this pull request Jul 24, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@holta holta holta approved these changes

Assignees

@deldesir deldesir

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@deldesir @holta