Skip to content

Prepend the video description with the source URL #183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 13, 2024
Merged

Prepend the video description with the source URL #183

merged 2 commits into from
Jun 13, 2024

Conversation

@deldesir
Copy link
Collaborator

Let the user know where the video came from by prepending its clickable URL. Each video downloaded will have this information at the very start of its description.
Context: #107

image

Tested on Ubuntu 24.04 (LRN2)

@deldesir deldesir added the enhancement New feature or request label Jun 13, 2024
@deldesir deldesir requested a review from holta June 13, 2024 18:04
@deldesir deldesir self-assigned this Jun 13, 2024
@holta
Copy link
Member

holta commented Jun 13, 2024 •
edited
Loading

Can you try this with a newline immediately after Source: URL ?

So that the (original!) video description begins just below that?

cc: @avni

@holta holta added the question Further information is requested label Jun 13, 2024
@deldesir
Copy link
Collaborator Author

I added 2 newlines, but it seems they have no effect. Investigating...

@deldesir
Copy link
Collaborator Author

deldesir commented Jun 13, 2024 •
edited
Loading

I ended up using <br> tag for the newline. I figured out descriptions are expected to be html/xml because they are sanitized using https://github.com/iiab/calibre-web/blob/9c8d8e7a16de8a13fafb2dbcae135a1bdbb4e65d/cps/clean_html.py#L41C1-L53C21

image

@holta holta merged commit 8f5ced1 into iiab:master Jun 13, 2024
@avni
Copy link
Member

avni commented Jun 13, 2024

Thank you!

@holta
Copy link
Member

holta commented Jun 13, 2024 •
edited
Loading

To Do:

  1. Many curriculum devs (parents, tutors, teachers, etc) will strongly prefer Source: URL on the very bottom of the description.

    To reduce distraction.

    “Offline First” is not just a slogan: this needs to be tried (soon).

  2. Other curatorial metadata like HH:MM:SS, e.g. video duration, will need to be surfaced far more prominently (for educators, kids, etc) in coming months — as summarized here:

    Display video/bookshelf original URL (or canonical URL if possible!) to all users [ASIDE: upload of offline video works, despite red error "Failed to Move Cover File" in web UI] #107 (comment)

This was referenced Jun 13, 2024
Open
Merged
@deldesir deldesir deleted the deldesir-patch-42 branch July 1, 2024 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@holta holta Awaiting requested review from holta

Assignees

@deldesir deldesir

Labels

enhancement New feature or request question Further information is requested

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@deldesir @holta @avni