Skip to content

Conversation

@deldesir
Copy link
Collaborator

@deldesir deldesir commented May 1, 2024

Enhance the log by recording the version of the underlying yt-dlp used by xklb.

@holta
Copy link
Member

holta commented May 1, 2024

Variables XKLB_EXECUTABLE and YT_DLP_EXECUTABLE add more complexity than genuine value in my own opinion:

  1. But either way, if they must be used, avoid dashes (hyphens) in bash variable names:

    https://unix.stackexchange.com/questions/23659/can-shell-variable-name-include-a-hyphen-or-dash

  2. Please confirm this PR is tested!

Background for this PR:

@holta holta marked this pull request as draft May 1, 2024 15:01
@holta holta added the enhancement New feature or request label May 1, 2024
@holta
Copy link
Member

holta commented May 2, 2024

@deldesir: revise/finalize this PR soon if possible?

@holta
Copy link
Member

holta commented May 2, 2024

Is this PR tested (ideally) — or ready for others like @EMG70 to test?

Thanks!!

@deldesir
Copy link
Collaborator Author

deldesir commented May 2, 2024

Variables XKLB_EXECUTABLE and YT_DLP_EXECUTABLE add more complexity than genuine value in my own opinion:

I removed their assignments since they are not used externally.

@deldesir deldesir self-assigned this May 2, 2024
@holta
Copy link
Member

holta commented May 2, 2024

Looks promising!

(Just let @EMG70, I & others know when we can hopefully test soon!)

@deldesir
Copy link
Collaborator Author

deldesir commented May 2, 2024

Ready to be tested and merged. I tested it on ubuntu 24.04 with cat /var/log/xklb.log | grep yt-dlp

root@box:/opt/iiab/iiab# cat /var/log/xklb.log | grep yt-dlp
2024-05-02 16:54:09 - [Info] Using yt-dlp 2024.04.09
2024-05-02 16:54:09 - [Debug] yt-dlp initialized 0.0749
2024-05-02 16:54:13 - [Info] Using yt-dlp 2024.04.09
2024-05-02 16:54:13 - [Debug] {'noprogress': True, 'lazy_playlist': True, 'noplaylist': True, 'no_check_certificate': True, 'ignore_no_formats_error': True, 'skip_playlist_after_errors': 21, 'playlistend': 20000, 'extractor_args': {'youtube': {'skip': ['authcheck']}}, 'logger': <xklb.createdb.tube_backend.download.<locals>.DictLogger object at 0x703f28e6e240>, 'postprocessors': [{'key': 'FFmpegMetadata'}, {'key': 'FFmpegEmbedSubtitle'}], 'restrictfilenames': True, 'playlist_items': '1', 'extractor_retries': 3, 'retries': 12, 'retry_sleep_functions': {'extractor': <function download.<locals>.<lambda> at 0x703f28542160>, 'http': <function download.<locals>.<lambda> at 0x703f28542200>, 'fragment': <function download.<locals>.<lambda> at 0x703f285422a0>}, 'outtmpl': {'default': '/library/downloads/calibre-web/%(extractor_key,extractor)s/%(uploader,uploader_id)s/%(title).200B_%(view_count)3.2D_[%(id).60B].%(ext)s', 'chapter': '/library/downloads/calibre-web/%(extractor_key,extractor)s/%(uploader,uploader_id)s/%(title).200B_%(section_number)03d_%(section_title)s_%(view_count)3.2D_[%(id).60B].%(ext)s'}, 'progress_hooks': [<function download.<locals>.<lambda> at 0x703f28542340>], 'subtitlesformat': 'srt/best', 'format': 'best', 'format_sort': ['tbr~1000'], 'writethumbnail': True, '_warnings': ['"-f best" selects the best pre-merged format which is often not the best option.\n         To let yt-dlp download and merge the best available formats, simply do not pass any format selection.\n         If you know what you are doing and want only the best pre-merged format, use "-f b" instead to suppress this warning']}

@deldesir deldesir marked this pull request as ready for review May 2, 2024 21:12
@deldesir deldesir requested a review from holta May 2, 2024 21:13
@holta holta merged commit 7c66091 into iiab:master May 2, 2024
@holta
Copy link
Member

holta commented May 2, 2024

@EMG70 can you test a fresh install of IIAB's Calibre-Web if you have a chance, now that this PR #159 is merged?

@holta holta mentioned this pull request May 2, 2024
1 task
@deldesir deldesir deleted the deldesir-patch-30 branch July 1, 2024 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants