Skip to content

Add additional media support #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 24, 2023
Merged

Add additional media support #1

merged 3 commits into from
Oct 24, 2023

Conversation

deldesir
Copy link
Collaborator

@deldesir deldesir commented Sep 15, 2023 •
edited
Loading

[Various] images and videos formats are added so they can be uploaded. Support to read them is also added.

@deldesir
Add additional media support
514b875 
[Various] images and videos formats are added so they can be uploaded.
@deldesir deldesir requested a review from holta September 15, 2023 02:13
@deldesir
Adjust route for additional media
9d248c8 
Videos and images are supported. They can "showed" using the usual "read" route.
@deldesir deldesir marked this pull request as draft September 15, 2023 02:35
@deldesir
Add additional media buttons
3281ef8 
Relevant media "reading" buutons are visible.
@deldesir deldesir marked this pull request as ready for review September 15, 2023 02:48
@holta
Copy link
Member

holta commented Sep 15, 2023

@deldesir can you/we (and everyone) use https://github.com/iiab/calibre-web/wiki to document supported (and unsupported!) media types like

calibre-web/cps/constants.py

Lines 145 to 147 in 3281ef8

EXTENSIONS_AUDIO = {'mp3', 'ogg', 'opus', 'wav', 'flac', 'm4a', 'm4b'}
EXTENSIONS_VIDEO = {'mp4', 'webm', 'avi', 'mkv', 'm4v', 'mpg', 'mpeg', 'ogv'}
EXTENSIONS_IMAGE = {'jpg', 'jpeg', 'png', 'gif', 'svg', 'webp'}
?

(Or is there a much better place?!)

@deldesir
Copy link
Collaborator Author

Yes, good idea.

@holta
Copy link
Member

holta commented Sep 15, 2023

This PR looks great!

Has it been smoke-tested?

If so I'm in favor of it being pushed ASAP to encourage broad community testing / further integration testing / etc — alongside succinct documentation of media types at https://github.com/iiab/calibre-web/wiki please!

PS we can (and no doubt will!) LATER tighten up & revise which media types are truly needed — and which should be desupported being far more trouble than they're worth — i.e. an eternal battle, e.g. just this week we learned that an iPhone 14 OS upgrade in recent weeks... very suddenly desupported some "audio codecs" when playing Kiwix videos (videos play but the sound can no longer be heard, on iPhone 14 only!) 😉

@deldesir deldesir self-assigned this Sep 15, 2023
@deldesir deldesir added the enhancement New feature or request label Sep 15, 2023
@deldesir
Copy link
Collaborator Author

Smoke-tested on Ubuntu 22.04. Please refer to https://github.com/iiab/calibre-web/wiki/Features-wiki#supported-media-formats for support status.

deldesir added a commit that referenced this pull request Sep 26, 2023
@deldesir
Merge pull request #1 from deldesir/master
c2da691 
feat: add video[book] playback support
@holta holta merged commit ce96f1a into master Oct 24, 2023
@deldesir deldesir deleted the deldesir-media-upload branch November 7, 2023 14:20
deldesir added a commit that referenced this pull request Nov 29, 2023
@deldesir
Merge pull request #1 from deldesir/deldesir-patch-3
6ee9e84 
Remove original file
@Akatama Akatama mentioned this pull request Jul 24, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@holta holta Awaiting requested review from holta

Assignees

@deldesir deldesir

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@deldesir @holta