-
Notifications
You must be signed in to change notification settings - Fork 11
3 regex's (STDERR, STDIN, Python) to parse yt-dlp download progress, for live display in "Tasks" view #93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
FYI @deldesir and @EMG70 this PR was tested to show live (real-time) display of "percentage download progress" in the web front-end's "Tasks" view. While carefully avoiding the pollution of So hopefully this PR (or similar) can be merged in short order if @deldesir's testing reconfirms this is on the right track! 🛤️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Elegant routing!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and ready for merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
@deldesir please in future feel free to improve on these REGEX's (preferably keeping all 3 aligned!) if there's a specific need ✅ |
Many Thanks to @EMG70 who reconfirmed — on Lines 1035-1316 here: |
I forgot to mention: This PR also changed log label "Warning" to "Debug" in As discussed earlier: |
This PR is a proposed alternative to:
Please see Lines 56-67 of
scripts/lb-wrapper
for an explanation of how this works. It refines:My apologies the PR below (90) might need to be rebased, after this PR #93 is hopefully merged soon:
Tangentially related: