Skip to content

Conversation

@holta holta added the bug Something isn't working label Jan 12, 2024
@holta holta requested a review from deldesir January 12, 2024 02:23
@holta
Copy link
Member Author

holta commented Jan 12, 2024

FYI @deldesir and @EMG70 this PR was tested to show live (real-time) display of "percentage download progress" in the web front-end's "Tasks" view.

While carefully avoiding the pollution of /var/log/calibre-web.log and /var/log/xklb.log — as subprocesses' STDERR and STDIN streams were polluting log files with duplicate/triplicate (and definitely ugly!) messages.

So hopefully this PR (or similar) can be merged in short order if @deldesir's testing reconfirms this is on the right track! 🛤️

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Elegant routing!

Copy link
Collaborator

@deldesir deldesir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and ready for merge.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@holta
Copy link
Member Author

holta commented Jan 12, 2024

@deldesir please in future feel free to improve on these REGEX's (preferably keeping all 3 aligned!) if there's a specific need ✅

@holta
Copy link
Member Author

holta commented Jan 12, 2024

Many Thanks to @EMG70 who reconfirmed — on Lines 1035-1316 here:

https://sprunge.us/1D9ieU?en#n-1035

@holta
Copy link
Member Author

holta commented Jan 12, 2024

I forgot to mention:

This PR also changed log label "Warning" to "Debug" in /var/log/xklb.log

As discussed earlier:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants