Remove advanced settings from "Download" modal dialog #81
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested on a Ubuntu 24.04 VM: This PR puts an end to the spreading of premature and false expectations about selecting 480p vs 720p vs 1080p (ETC). The user/implementer should instead directly customize calibre-web/scripts/lb-wrapper Line 8 in 1ca10c9 Later in 2024, the "Download to IIAB" button should validate-and-parse implementer/user's input URL. Example: Playlists and channels might be auto-detected — asking the implementer/user (almost immediately) to choose among...
Ideally each such/above option would also specify... a few seconds later... the estimated total amount of storage (GB) required!? Related:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use only the URL for now.