Skip to content

Fix missing cover [for MP4; not just WebM] #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 7, 2023
Merged

Fix missing cover [for MP4; not just WebM] #59

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions cps/uploader.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -268,7 +268,14 @@ def video_metadata(tmp_file_path, original_file_name, original_file_extension):
pubdate = datetime.datetime.fromtimestamp(pubdate).strftime('%Y-%m-%d %H:%M:%S')

# read row[path] to get video file, replace its extension with .webp
cover_file_path = row['path'].replace('.webm', '.webp')
if os.path.isfile(row['path'].replace('.webm', '.webp')):
cover_file_path = row['path'].replace('.webm', '.webp')
elif os.path.isfile(row['path'].replace('.mp4', '.webp')):
cover_file_path = row['path'].replace('.mp4', '.webp')
else:
# if no .webm or .mp4 file exists, log a warning and use the default cover
log.warning('Cannot find .webm or .mp4 file, using default cover')
cover_file_path = os.path.splitext(tmp_file_path)[0] + '.cover.jpg'
meta = BookMeta(
file_path=tmp_file_path,
extension=original_file_extension,
Expand All @@ -286,7 +293,7 @@ def video_metadata(tmp_file_path, original_file_name, original_file_extension):
return meta
conn.close()
else:
log.warning('Cannot find download.db, using default')
log.warning('Cannot find survey database, using default metadata')
else:
meta = BookMeta(
file_path=tmp_file_path,
Expand Down