fix: Apps Stdout is redirected to Stderr #3953
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julienrbrt
previously approved these changes
Feb 6, 2024
Member
julienrbrt
left a comment
There was a problem hiding this comment.
ACK. Can we get a changelog?
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #3953 +/- ##
=======================================
Coverage 24.78% 24.78%
=======================================
Files 296 296
Lines 24901 24896 -5
=======================================
- Hits 6171 6170 -1
+ Misses 18164 18160 -4
Partials 566 566
|
Contributor
Author
|
@julienrbrt I believe that this issue wasn't in v28.1.1 release so i'm not sure if it requires changelog. |
Member
|
It does as we've released v28.2.0 |
julienrbrt
approved these changes
Feb 6, 2024
mergify bot
pushed a commit
that referenced
this pull request
Feb 6, 2024
* Fix stdout redirecting to stderr * Fix unit test * Update changelog (cherry picked from commit ca4445e)
julienrbrt
added a commit
that referenced
this pull request
Feb 6, 2024
* fix: Apps Stdout is redirected to Stderr (#3953) * Fix stdout redirecting to stderr * Fix unit test * Update changelog (cherry picked from commit ca4445e) * fix conflicts --------- Co-authored-by: Ehsan-saradar <[email protected]> Co-authored-by: Julien Robert <[email protected]>
Merged
julienrbrt
pushed a commit
that referenced
this pull request
May 29, 2024
* Fix stdout redirecting to stderr * Fix unit test * Update changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3951