refactor(cosmover): delete notion of app version #3903
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julienrbrt
commented
Jan 24, 2024
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #3903 +/- ##
=======================================
Coverage 24.69% 24.69%
=======================================
Files 297 296 -1
Lines 24845 24841 -4
=======================================
Hits 6135 6135
+ Misses 18148 18144 -4
Partials 562 562
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I came across a notion of app version, which does not really make sense.
We do not need to have a default build tag either, and should let the user specify it if needed.