Skip to content

fix(cmd): fix cobra completion #3905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 25, 2024
Merged

fix(cmd): fix cobra completion #3905

merged 2 commits into from
Jan 25, 2024

Conversation

@julienrbrt
Copy link
Member

@julienrbrt julienrbrt commented Jan 24, 2024

Closes: #3896

@github-actions github-actions bot added component:ci CI/CD workflow and automated jobs. component:configs component:cmd labels Jan 24, 2024
@codecov
Copy link

codecov bot commented Jan 24, 2024 •
edited
Loading

Codecov Report

Attention: 22 lines in your changes are missing coverage. Please review.

Comparison is base (f96ab07) 24.71% compared to head (73876b9) 24.69%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3905      +/-   ##
==========================================
- Coverage   24.71%   24.69%   -0.03%     
==========================================
  Files         296      297       +1     
  Lines       24824    24845      +21     
==========================================
  Hits         6135     6135              
- Misses      18127    18148      +21     
  Partials      562      562
Files Coverage Δ
ignite/cmd/cmd.go 5.94% <0.00%> (-0.04%) ⬇️
ignite/cmd/completion.go 0.00% <0.00%> (ø)

@julienrbrt julienrbrt enabled auto-merge (squash) January 25, 2024 08:28
@julienrbrt julienrbrt merged commit 18e5fc9 into main Jan 25, 2024
@julienrbrt julienrbrt deleted the julien/cobra-completion branch January 25, 2024 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jeronimoalbi jeronimoalbi jeronimoalbi approved these changes

@ilgooz ilgooz Awaiting requested review from ilgooz ilgooz is a code owner

@salmad3 salmad3 Awaiting requested review from salmad3

@toschdev toschdev Awaiting requested review from toschdev

@Pantani Pantani Awaiting requested review from Pantani Pantani is a code owner

@Ehsan-saradar Ehsan-saradar Awaiting requested review from Ehsan-saradar

Assignees

@julienrbrt julienrbrt

Labels

component:ci CI/CD workflow and automated jobs. component:cmd component:configs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ignite completion unknown command

3 participants

@julienrbrt @jeronimoalbi