feat(pkg/cache): support version prefix #3829
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julienrbrt
previously approved these changes
Dec 8, 2023
Member
julienrbrt
left a comment
There was a problem hiding this comment.
lgtm, but it would be great to add unit tests.
Should we as well let ignite doctor clear the ignite cache?
Pantani
previously approved these changes
Dec 8, 2023
b442c07
Pantani
previously approved these changes
Dec 12, 2023
Pantani
previously approved these changes
Dec 12, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3829 +/- ##
==========================================
+ Coverage 24.32% 24.36% +0.03%
==========================================
Files 293 294 +1
Lines 24538 24555 +17
==========================================
+ Hits 5970 5982 +12
- Misses 18032 18036 +4
- Partials 536 537 +1
|
820f378
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cache can optionally prefix keys with a version when available through the storage.
Ignite CLI version is used as key prefix for cached values to avoid potential issues when major CLI updates are released, making
--clear-cacheoptional.The
--clear-cachecan still be used to clear all cached values when necessary.