Skip to content

fix: correct invalid plugin hook check #3716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 27, 2023
Merged

fix: correct invalid plugin hook check #3716

merged 3 commits into from
Oct 27, 2023

Conversation

@jeronimoalbi
Copy link
Member

@jeronimoalbi jeronimoalbi commented Oct 27, 2023

No description provided.

@jeronimoalbi jeronimoalbi added type:error Something isn't working component:apps Related to Ignite Apps. labels Oct 27, 2023
@jeronimoalbi jeronimoalbi self-assigned this Oct 27, 2023
@github-actions github-actions bot added component:ci CI/CD workflow and automated jobs. component:configs component:cmd labels Oct 27, 2023
@codecov
Copy link

codecov bot commented Oct 27, 2023

Codecov Report

Merging #3716 (bbb778e) into main (6f98b6c) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3716   +/-   ##
=======================================
  Coverage   24.71%   24.71%           
=======================================
  Files         289      289           
  Lines       23945    23945           
=======================================
  Hits         5918     5918           
  Misses      17494    17494           
  Partials      533      533
Files Coverage Δ
ignite/cmd/plugin.go 27.77% <100.00%> (ø)

@jeronimoalbi jeronimoalbi mentioned this pull request Oct 27, 2023
Closed
@jeronimoalbi jeronimoalbi marked this pull request as ready for review October 27, 2023 07:51
@jeronimoalbi jeronimoalbi merged commit 3050e62 into main Oct 27, 2023
@jeronimoalbi jeronimoalbi deleted the fix/invalid-plugin-hook-check branch October 27, 2023 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@julienrbrt julienrbrt julienrbrt approved these changes

@ilgooz ilgooz Awaiting requested review from ilgooz ilgooz is a code owner

@Pantani Pantani Awaiting requested review from Pantani Pantani is a code owner

@Ehsan-saradar Ehsan-saradar Awaiting requested review from Ehsan-saradar

Assignees

@jeronimoalbi jeronimoalbi

Labels

component:apps Related to Ignite Apps. component:ci CI/CD workflow and automated jobs. component:cmd component:configs type:error Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jeronimoalbi @julienrbrt