Skip to content

feat: update ts-relayer version #3601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Aug 21, 2023
Merged

feat: update ts-relayer version #3601

merged 9 commits into from
Aug 21, 2023

Conversation

@jeronimoalbi
Copy link
Member

@jeronimoalbi jeronimoalbi commented Jul 27, 2023 •
edited
Loading

This PR fixes ignite relayer command:

  • Update ts-relayer to v0.10.0 (adds support for CometBFT)
  • Update cosmjs to v0.31.1 (fixes auto gas multiplier issue)

@jeronimoalbi jeronimoalbi self-assigned this Jul 27, 2023
@jeronimoalbi
Copy link
Member Author

jeronimoalbi commented Jul 27, 2023

This PR was intended to update confio/ts-relater to the latest version to fix issue #3541.

The reported issue won't be fixed with this PR because ts-relayer is using a client for Tendermint v0.34

@github-actions github-actions bot added component:ci CI/CD workflow and automated jobs. component:configs labels Aug 10, 2023
@jeronimoalbi
feat: update ts-relayer version to v0.10.0
1ca10a9 
This new version contains a fix to make it work with the lates
Tendermint version.
@jeronimoalbi
chore: update nodetime dependencies and package lock
eb2bb30
@jeronimoalbi jeronimoalbi mentioned this pull request Aug 17, 2023
Closed
@jeronimoalbi jeronimoalbi marked this pull request as ready for review August 21, 2023 08:26
clockworkgr
clockworkgr reviewed Aug 21, 2023
View reviewed changes
Copy link
Collaborator

@clockworkgr clockworkgr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

However it seems only part of the deps have been updated in the lock file (shouldn't matter much as cosmjs is also explicitly versioned in our package.json) + the lock file is version 3 (i assumed you npm installed with node 18)

Since we target node 16 in the pkg nodetime, I think it's best if you:

  • completely remove node_modules and package-lock.json
  • run npm install using node v16 (I suggest using https://github.com/nvm-sh/nvm)
  • run './scripts/gen-nodetime` and build CLI again
  • test
  • commit the resulting package-lock if all fine

@jeronimoalbi
Copy link
Member Author

jeronimoalbi commented Aug 21, 2023

Looks good.

However it seems only part of the deps have been updated in the lock file (shouldn't matter much as cosmjs is also explicitly versioned in our package.json) + the lock file is version 3 (i assumed you npm installed with node 18)

Since we target node 16 in the pkg nodetime, I think it's best if you:

  • completely remove node_modules and package-lock.json
  • run npm install using node v16 (I suggest using https://github.com/nvm-sh/nvm)
  • run './scripts/gen-nodetime` and build CLI again
  • test
  • commit the resulting package-lock if all fine

It makes sense, thanks @clockworkgr 👍
I will make the changes.

@ilgooz ilgooz merged commit e4ef6df into main Aug 21, 2023
@ilgooz ilgooz deleted the feat/update-tsrelayer-version branch August 21, 2023 13:09
@jeronimoalbi jeronimoalbi mentioned this pull request Oct 9, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ilgooz ilgooz ilgooz approved these changes

@clockworkgr clockworkgr clockworkgr approved these changes

@Pantani Pantani Awaiting requested review from Pantani Pantani is a code owner

Assignees

@jeronimoalbi jeronimoalbi

Labels

component:ci CI/CD workflow and automated jobs. component:configs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jeronimoalbi @ilgooz @clockworkgr @Pantani