fix: upgrade Cosmos SDK app compatibility check #3523
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The format was improved for better readability and the warning icon removed because it was not rendered properly.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3523 +/- ##
==========================================
- Coverage 23.99% 23.99% -0.01%
==========================================
Files 295 295
Lines 23747 23753 +6
==========================================
Hits 5699 5699
- Misses 17539 17544 +5
- Partials 509 510 +1
|
Pantani
reviewed
May 31, 2023
Collaborator
|
For some reason, the error message was sometimes sliced. Maybe we should add a broken line, and also, we can add a message if the user doesn't want the upgrade the chain, he can use an older version of the CLI |
Member
Author
I tried locally multiple times and I don't see the issue but neither can we be sure it's related to a local setup issue. I would leave it as it is for now and reformat it if the problem reappears. |
Pantani
approved these changes
Jun 1, 2023
Jchicode
pushed a commit
to Jchicode/cli
that referenced
this pull request
Aug 9, 2023
* refactor: unify cosmos module path constant * chore: add new COmos SDK versions to `comosover` pkg * refactor: add assert for min supported Cosmos SDK version * refactor: change scaffolder to assert minimum supported SDK version * fix: correct SDK version error message The format was improved for better readability and the warning icon removed because it was not rendered properly. * chore: add changelog entry * fix: correct error string to pass CI * feat: add chain option to check for supported Cosmos SDK version * chore: change variable name for error message constant * chore: correct error message
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3515