Skip to content

Conversation

@smuu
Copy link
Contributor

@smuu smuu commented Apr 11, 2023

Resolves #3480

Checksum format <sha256sum><space><space><file_name> instead of <sha256sum><space><file_name>.

Reference see here:

The sums are computed as described in FIPS-180-2. When checking, the input should be a former output of this program. The default mode is to print a line with checksum, a character indicating type ('*' for binary, ' ' for text), and name for each FILE.

@codecov
Copy link

codecov bot commented Apr 11, 2023

Codecov Report

Merging #3481 (5e022f7) into main (f68a0c2) will increase coverage by 0.00%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3481   +/-   ##
=======================================
  Coverage   23.69%   23.70%           
=======================================
  Files         300      300           
  Lines       23697    23697           
=======================================
+ Hits         5615     5617    +2     
+ Misses      17577    17576    -1     
+ Partials      505      504    -1     
Impacted Files Coverage Δ
ignite/pkg/checksum/checksum.go 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

jeronimoalbi
jeronimoalbi previously approved these changes Apr 11, 2023
Copy link
Member

@jeronimoalbi jeronimoalbi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @smuu!

@jeronimoalbi jeronimoalbi merged commit 2a656af into ignite:main Apr 13, 2023
@smuu smuu deleted the bugfix/checksum-correct-format branch April 13, 2023 13:13
Jchicode pushed a commit to Jchicode/cli that referenced this pull request Aug 9, 2023
* fix: correct checksum format

Signed-off-by: Smuu <[email protected]>

* docs: add changelog entry

Signed-off-by: Smuu <[email protected]>

* chore: add comment on checksum entry format

---------

Signed-off-by: Smuu <[email protected]>
Co-authored-by: Jerónimo Albi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The format of the release checksum does not comply with the standard

2 participants