-
Notifications
You must be signed in to change notification settings - Fork 572
feat: plugin describe command #3105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Also thinking of adding an |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice addition, I was thinking of something like this because with the hook addition we need to show what the plugin is actually doing.
The current implementation breaks a little bit the concept of a list, because a plugin description takes multiple lines. For instance if my project has 2 plugins configured, the output of ignite plugin list is :
$ ignite plugin list
ℹ️ example-plugin info
Path Status
/home/tom/src/ignite/plugins/plugin-example ✅ Loaded
💻 Commands
Use Under
ipfs ignite
shutdown ipfs
🪝 Hooks
Name On Command
my-hook-serve ignite chain serve
my-hook-build ignite chain build
ℹ️ my-new-plugin info
Path Status
/home/tom/src/ignite/plugins/my-new-plugin ✅ Loaded
💻 Commands
Use Under
my-new-plugin ignite
🪝 Hooks
Name On Command
I think we should keep the table format for plugin list, with a reduced set of information, for instance we could use the nice icons you added :
$ ignite plugin list
Path Status
/home/tom/src/ignite/plugins/plugin-example ✅ Loaded 2🪝 1💻
/home/tom/src/ignite/plugins/my-new-plugin ✅ Loaded 1💻
Then to have the complete description, we need to add a new command ignite plugin describe <pluginPath> that would output everything like you did but for a single plugin.
WDYT?
I think this is a good path forward, I originally isolated the |
|
when I merged main into this branch there were suddenly many more file changes. tried to revert the merge of main but can't seem to get an accurate delta count |
|
@joshLong145 I can't explain what happened, this is confusing. Probably related to the multiple merge between develop and rebase on main. I think the best way to fix this is to rewrite the history. I was able to have the correct diff (I think) with the following commands from your branch : Check if the diff is now correct ( |
fd725fb to
366e990
Compare
…into feat/plugin-list-cmd-updates
|
@tbruyelle @aljo242 I've reworked |
…into feat/plugin-list-cmd-updates
…into feat/plugin-list-cmd-updates
* patch apply from declare changes * update to changelog * moving of changelog update * newline addition * clean up * removing error return * moving to session based table output for list and declare plugin * moved table output outside loop * return errors and output empty lists * updates per review comments * review comments Co-authored-by: Alex Johnson <[email protected]> Co-authored-by: Thomas Bruyelle <[email protected]>
hookandcommandinfo output onignite plugin list