refactor: remove legacy launchpad code #3033
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
tbruyelle
previously approved these changes
Nov 2, 2022
tbruyelle
approved these changes
Nov 2, 2022
lumtis
approved these changes
Nov 2, 2022
Contributor
lumtis
left a comment
There was a problem hiding this comment.
We have the Plugin interface in services/chain that could be removed unless we consider it as future proof in case new version with different API come up, but it seems unlikely
It complexifies the codebase right now
Contributor
Author
We should at least modify the name from |
Contributor
|
Great, let's merge this one |
Jchicode
pushed a commit
to Jchicode/cli
that referenced
this pull request
Aug 9, 2023
* remove family * remove family * remove StarportOnlySupported error * remove dead code * lint fixes * changelog Co-authored-by: Lucas Bertrand <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cosmosverpkg by removing theFamilyfield.