Skip to content

IBX-10124: Add support for Argon2 password hashes #581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
glye wants to merge 28 commits into
base: main
Choose a base branch
from
Open

IBX-10124: Add support for Argon2 password hashes #581

Changes from 1 commit
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
e44627b
IBX-10124: Added basic support for Argon2I(D) password hashes
glye Jun 5, 2025
5066a14
Disable setConfigResolver for CI test
glye Jul 30, 2025
07b297b
Revert "Disable setConfigResolver for CI test"
glye Jul 30, 2025
3ef4b6b
Set config resolver in constructor
glye Jul 30, 2025
688559c
Add settings to CI
glye Jul 31, 2025
ef4cafc
Fix password fail logic when not upgrading hash type
glye Jul 31, 2025
2993321
Remove unneeded docblock
glye Aug 1, 2025
77b1de0
CS?
glye Aug 1, 2025
132e4ab
Remove unneeded docblock
glye Aug 1, 2025
7cddb7b
Simplify by breaking constructor BC
glye Aug 1, 2025
b0b111a
Use actual const in yaml config example
glye Aug 1, 2025
b9074bf
Review feedback
glye Aug 1, 2025
b375fe1
Review feedback
glye Aug 1, 2025
ebb1e73
Review feedback: FQCN in config hint
glye Aug 1, 2025
ad0d728
Compile time check for Argon2 support in PHP
glye Aug 1, 2025
47b9956
Skip logger check, CS
glye Aug 1, 2025
0849c9a
phpstan logger ignore
glye Aug 1, 2025
7785736
Use LoggerAwareTrait
glye Aug 1, 2025
37b3bf6
Rename method
glye Aug 1, 2025
c50ce8d
Fix logger set in ctor
glye Aug 1, 2025
c8dc564
Regenerated phpstan baseline
glye Aug 1, 2025
69b2595
Revert "Regenerated phpstan baseline"
glye Aug 1, 2025
dccab56
Add logger to ctor params
glye Aug 1, 2025
2a44774
Updated phpstan baseline
glye Aug 1, 2025
f7c2aba
!php/const in docblock example
glye Aug 5, 2025
567d150
Improved config validation error message
glye Aug 6, 2025
23b1d0e
Made repository aware (incomplete)
glye Aug 8, 2025
fca04e0
Pass repo settings directly to the hasher
glye Aug 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Revert "Regenerated phpstan baseline" 
This reverts commit 2d86b6f.
  • Loading branch information
@glye @adamwojs
glye authored and adamwojs committed Oct 14, 2025
commit 69b2595dd735cc0b832f8e764a961c30cf32fa97
60 changes: 42 additions & 18 deletions phpstan-baseline.neon
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,12 +156,6 @@ parameters:
count: 1
path: src/bundle/Core/Command/ReindexCommand.php

-
message: '#^Parameter \#2 \$subject of function preg_match expects string, string\|false given\.$#'
identifier: argument.type
count: 1
path: src/bundle/Core/Command/ReindexCommand.php

-
message: '#^Parameter \#2 \$subject of function preg_match_all expects string, string\|false given\.$#'
identifier: argument.type
Expand Down Expand Up @@ -3852,6 +3846,18 @@ parameters:
count: 2
path: src/bundle/Core/URLChecker/Handler/AbstractURLHandler.php

-
message: '#^Cannot call method error\(\) on Psr\\Log\\LoggerInterface\|null\.$#'
identifier: method.nonObject
count: 1
path: src/bundle/Core/URLChecker/Handler/AbstractURLHandler.php

-
message: '#^Cannot call method info\(\) on Psr\\Log\\LoggerInterface\|null\.$#'
identifier: method.nonObject
count: 1
path: src/bundle/Core/URLChecker/Handler/AbstractURLHandler.php

-
message: '#^Method Ibexa\\Bundle\\Core\\URLChecker\\Handler\\AbstractURLHandler\:\:getOptions\(\) return type has no value type specified in iterable type array\.$#'
identifier: missingType.iterableValue
Expand Down Expand Up @@ -3906,6 +3912,12 @@ parameters:
count: 1
path: src/bundle/Core/URLChecker/Handler/MailToHandler.php

-
message: '#^Cannot call method error\(\) on Psr\\Log\\LoggerInterface\|null\.$#'
identifier: method.nonObject
count: 1
path: src/bundle/Core/URLChecker/URLChecker.php

-
message: '#^Method Ibexa\\Bundle\\Core\\URLChecker\\URLChecker\:\:check\(\) has no return type specified\.$#'
identifier: missingType.return
Expand Down Expand Up @@ -10320,6 +10332,12 @@ parameters:
count: 1
path: src/lib/Persistence/Cache/Handler.php

-
message: '#^Cannot call method debug\(\) on Psr\\Log\\LoggerInterface\|null\.$#'
identifier: method.nonObject
count: 1
path: src/lib/Persistence/Cache/Identifier/CacheIdentifierGenerator.php

-
message: '#^Method Ibexa\\Core\\Persistence\\Cache\\Identifier\\CacheIdentifierGenerator\:\:__construct\(\) has parameter \$keyPatterns with no value type specified in iterable type array\.$#'
identifier: missingType.iterableValue
Expand Down Expand Up @@ -15288,12 +15306,6 @@ parameters:
count: 1
path: src/lib/Persistence/Legacy/Notification/Gateway.php

-
message: '#^Function Ibexa\\PolyfillPhp82\\iterator_to_array not found\.$#'
identifier: function.notFound
count: 1
path: src/lib/Persistence/Legacy/Notification/Gateway/DoctrineDatabase.php

-
message: '#^Method Ibexa\\Core\\Persistence\\Legacy\\Notification\\Gateway\\DoctrineDatabase\:\:__construct\(\) has parameter \$criterionHandlers with generic interface Ibexa\\Contracts\\Core\\Repository\\Values\\Notification\\CriterionHandlerInterface but does not specify its types\: T$#'
identifier: missingType.generics
Expand Down Expand Up @@ -15324,12 +15336,6 @@ parameters:
count: 1
path: src/lib/Persistence/Legacy/Notification/Gateway/DoctrineDatabase.php

-
message: '#^Used function Ibexa\\PolyfillPhp82\\iterator_to_array not found\.$#'
identifier: function.notFound
count: 1
path: src/lib/Persistence/Legacy/Notification/Gateway/DoctrineDatabase.php

-
message: '#^Dead catch \- Doctrine\\DBAL\\Exception is never thrown in the try block\.$#'
identifier: catch.neverThrown
Expand Down Expand Up @@ -16914,6 +16920,12 @@ parameters:
count: 1
path: src/lib/Repository/ContentTypeService.php

-
message: '#^Cannot call method error\(\) on Psr\\Log\\LoggerInterface\|null\.$#'
identifier: method.nonObject
count: 1
path: src/lib/Repository/Helper/RelationProcessor.php

-
message: '#^Method Ibexa\\Core\\Repository\\Helper\\RelationProcessor\:\:appendFieldRelations\(\) has no return type specified\.$#'
identifier: missingType.return
Expand Down Expand Up @@ -17058,6 +17070,12 @@ parameters:
count: 1
path: src/lib/Repository/Mapper/ContentDomainMapper.php

-
message: '#^Cannot call method error\(\) on Psr\\Log\\LoggerInterface\|null\.$#'
identifier: method.nonObject
count: 1
path: src/lib/Repository/Mapper/ContentDomainMapper.php

-
message: '#^Method Ibexa\\Core\\Repository\\Mapper\\ContentDomainMapper\:\:buildContentDomainObject\(\) has parameter \$prioritizedLanguages with no value type specified in iterable type array\.$#'
identifier: missingType.iterableValue
Expand Down Expand Up @@ -18246,6 +18264,12 @@ parameters:
count: 1
path: src/lib/Repository/UserService.php

-
message: '#^Method Ibexa\\Core\\Repository\\UserService\:\:setLogger\(\) has no return type specified\.$#'
identifier: missingType.return
count: 1
path: src/lib/Repository/UserService.php

-
message: '#^PHPDoc tag @param for parameter \$id with type mixed is not subtype of native type int\.$#'
identifier: parameter.phpDocType
Expand Down