Skip to content

WIP: Update Junit/Mockito #837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

WIP: Update Junit/Mockito #837

wants to merge 3 commits into from

Conversation

delanym
Copy link

@delanym delanym commented Oct 28, 2023

Are you open to an aggressive migration to JUnit5? Aggressive meaning to potentially disable non-trivial issues?

@delanym delanym force-pushed the delany/update-testing branch 2 times, most recently from deb2929 to 3e79482 Compare October 28, 2023 11:34
@delanym
Copy link
Author

delanym commented Oct 28, 2023

Is this the time to avoid container in a unit test anti-pattern?
https://izpack.atlassian.net/wiki/spaces/IZPACK/pages/491531/How+to+use+PicoContainer+with+JUnit

@reinhapa
Copy link
Member

Is this the time to avoid container in a unit test anti-pattern? https://izpack.atlassian.net/wiki/spaces/IZPACK/pages/491531/How+to+use+PicoContainer+with+JUnit

We got a problem with PicoContainer anyway in order to support the latest JDKs. Unfortunately I did not had the time to work on this problem so far.

@delanym
Copy link
Author

delanym commented Oct 28, 2023

Yes I see it looks abandoned https://github.com/picocontainer/picocontainer
Please let me know what decision is taken about an alternative and how I can contribute.

@reinhapa
Copy link
Member

I did some trials in using Weld CDI in my separate PR #779, but did not have enough time to work more on this lately...

@reinhapa
Copy link
Member

@delanym the current master branch is now updated to target Java 17+. You may rebase your work again...

@delanym delanym force-pushed the delany/update-testing branch from 3e79482 to bb998c1 Compare April 19, 2025 07:29
@delanym
Copy link
Author

delanym commented Apr 19, 2025

Updated, but there's an issue with loading the byte buddy agent in the core tests.

@reinhapa
Copy link
Member

@delanym any update on this?

@delanym
Copy link
Author

delanym commented Jun 18, 2025

@reinhapa nope. I'm swamped with other stuff

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@delanym @reinhapa