Skip to content

Conversation

@ralflang
Copy link
Member

@ralflang ralflang commented Jun 19, 2025

See also #5 - We should really not use return parameters. Forms is already confusing enough.

As recommended there:

  • Callers need to upgrade getInfo(...) to $info = getInfo(...) where this has not happened yet
  • derived types need to return array $info in getInfo
  • Callers need to add getMessage after isValid if they actually use the message
  • derived types need to set $this->message before return if they actually set a message
  • Let's draft a largely compatible V3 namespaced versions if the breaks proposed by @amulet1 in fix: Correct Horde_Form_Type::isValid() signature #5
  • Let's keep more involved changes for V4 with PHP 8.4 baseline

@ralflang ralflang merged commit 99aec68 into FRAMEWORK_6_0 Jun 20, 2025
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants