Skip to content

Conversation

mezz64
Copy link
Contributor

@mezz64 mezz64 commented Mar 1, 2020

Proposed change

Update pyeight to 0.1.4 to fix error in set heat service.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@codecov
Copy link

codecov bot commented Mar 1, 2020

Codecov Report

Merging #32363 into dev will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev   #32363   +/-   ##
=======================================
  Coverage   94.75%   94.75%           
=======================================
  Files         775      775           
  Lines       56171    56171           
=======================================
  Hits        53224    53224           
  Misses       2947     2947           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e3492d...e8b6f62. Read the comment docs.

@Danielhiversen Danielhiversen merged commit e9206b2 into home-assistant:dev Mar 1, 2020
balloob pushed a commit that referenced this pull request Mar 3, 2020
@balloob balloob mentioned this pull request Mar 3, 2020
@lock lock bot locked and limited conversation to collaborators Mar 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

eight_sleep.heat_set fails with "'bool' object is not callable" error

5 participants