Fix incorrect status updates for lcn #159251
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes broken functionality in the LCN integration caused by incorrect handling of status messages from the hardware. The fix involves upgrading the pypck library dependency from 0.9.7 to 0.9.8 and adjusting the parallel updates and scan intervals across multiple platforms.
Key changes:
- Updates pypck dependency to version 0.9.8 to fix underlying library issues
- Changes PARALLEL_UPDATES from 0 to 2 across all affected platforms
- Increases SCAN_INTERVAL from 1 minute to 10 minutes for platforms with push-based updates (switch, light, binary_sensor)
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| requirements_all.txt | Updates pypck dependency version to 0.9.8 |
| requirements_test_all.txt | Updates pypck test dependency version to 0.9.8 |
| homeassistant/components/lcn/manifest.json | Updates pypck requirement in integration manifest |
| homeassistant/components/lcn/binary_sensor.py | Sets PARALLEL_UPDATES to 2 and SCAN_INTERVAL to 10 minutes |
| homeassistant/components/lcn/climate.py | Sets PARALLEL_UPDATES to 2 |
| homeassistant/components/lcn/cover.py | Sets PARALLEL_UPDATES to 2 |
| homeassistant/components/lcn/light.py | Sets PARALLEL_UPDATES to 2 and SCAN_INTERVAL to 10 minutes |
| homeassistant/components/lcn/scene.py | Sets PARALLEL_UPDATES to 2 |
| homeassistant/components/lcn/sensor.py | Sets PARALLEL_UPDATES to 2 |
| homeassistant/components/lcn/switch.py | Sets PARALLEL_UPDATES to 2 and SCAN_INTERVAL to 10 minutes |
zweckj
requested changes
Dec 17, 2025
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
967496a to
76eaead
Compare
zweckj
approved these changes
Dec 18, 2025
|
Dear home-assistant team, please release the fix as soon as possible, as it is very annoying to "loose" connections every few minutes/hours. Thank you so much! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Recent changes in the lcn integration broke functionality for several users due to incorrect handling of status messages from the hardware.
See #159104, #158892, #158059
To fix this, adjustments had to be made in the underlying library as well as to the parallel updates and their frequency.
Please note: Some of the LCN status changes are pushed to HA, while others need to be polled. For the former ones, the update interval has been set to 10 minutes, which is perfectly adequate.
The dependency upgrade is in a separate PR: #159277
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: