Support KNX text entity configuration from UI #159509
Open
+278
−37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey there @Julius2342, @marvin-w, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
8 tasks
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds support for configuring KNX text entities through the Home Assistant UI (in addition to the existing YAML configuration). This brings the text platform in line with other KNX platforms that already support UI configuration.
Key changes:
- Refactored text entity classes to support both YAML and UI configuration sources
- Added UI schema validation and websocket API support for text entities
- Implemented comprehensive test coverage for UI-created and UI-loaded text entities
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| homeassistant/components/knx/text.py | Refactored entity classes: split into base _KnxText, KnxYamlText for YAML config, and new KnxUiText for UI config; updated setup to handle both config sources |
| homeassistant/components/knx/storage/entity_store_schema.py | Added TEXT_KNX_SCHEMA validation schema for UI configuration with group address, mode, respond_to_read, and sync_state fields |
| homeassistant/components/knx/storage/const.py | Added CONF_GA_TEXT constant for text group address configuration key |
| homeassistant/components/knx/const.py | Added Platform.TEXT to SUPPORTED_PLATFORMS_UI to enable UI configuration |
| homeassistant/components/knx/strings.json | Added translation strings for text platform UI configuration including descriptions and labels |
| tests/components/knx/test_text.py | Added test_text_ui_create and test_text_ui_load tests to verify UI configuration creation and storage loading |
| tests/components/knx/snapshots/test_websocket.ambr | Added snapshot for text platform schema returned by websocket API |
| tests/components/knx/fixtures/config_store_text.json | Added test fixture with sample stored text entity configuration |
Co-authored-by: Copilot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Support KNX text entity configuration from UI
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: