Skip to content

Bump python-roborock to 3.19.0 #159404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zweckj merged 1 commit into from
Dec 19, 2025
Merged

Bump python-roborock to 3.19.0 #159404

zweckj merged 1 commit into from
Dec 19, 2025
+3 −3

Conversation

@allenporter
Copy link
Contributor

@allenporter allenporter commented Dec 19, 2025

Proposed change

Bump python-roborock to 3.19.0
Changes: Python-roborock/python-roborock@v3.18.0...v3.19.0

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@allenporter allenporter added this to the 2025.12.4 milestone Dec 19, 2025
Copilot AI review requested due to automatic review settings December 19, 2025 04:17
@home-assistant
Copy link

home-assistant bot commented Dec 19, 2025

Hey there @Lash-L, mind taking a look at this pull request as it has been labeled with an integration (roborock) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of roborock can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign roborock Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

Copilot AI reviewed Dec 19, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR bumps the python-roborock library dependency from version 3.18.0 to 3.19.0 to fix a bug (issue #158049). The upgrade is a straightforward dependency version update with no associated code changes required in the Roborock integration.

Key changes:

  • Updated python-roborock dependency from 3.18.0 to 3.19.0 across all requirement files

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
requirements_all.txt Updated python-roborock version to 3.19.0
requirements_test_all.txt Updated python-roborock version to 3.19.0 for test dependencies
homeassistant/components/roborock/manifest.json Updated python-roborock requirement to 3.19.0 in integration manifest

@zweckj zweckj merged commit 92cf762 into home-assistant:dev Dec 19, 2025
67 of 69 checks passed
bramkragten pushed a commit that referenced this pull request Dec 19, 2025
@allenporter @bramkragten
Bump python-roborock to 3.19.0 (#159404)
cec5134
@bramkragten bramkragten mentioned this pull request Dec 19, 2025
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Dec 20, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

Copilot code review Copilot Copilot left review comments

@zweckj zweckj zweckj approved these changes

Assignees

No one assigned

Labels

bugfix by-code-owner cherry-picked cla-signed dependency integration: roborock Quality Scale: silver small-pr PRs with less than 30 lines.

Projects

None yet

Milestone

2025.12.4

Development

Successfully merging this pull request may close these issues.

Roborock only adds first three robots

3 participants

@allenporter @zweckj @bramkragten