Skip to content

Bump aioasuswrt 1.5.3 #158882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
joostlek merged 1 commit into from
Dec 13, 2025
Merged

Bump aioasuswrt 1.5.3 #158882

joostlek merged 1 commit into from
Dec 13, 2025
+3 −3

Conversation

@kennedyshead
Copy link
Contributor

@kennedyshead kennedyshead commented Dec 12, 2025 •
edited
Loading

Proposed change

Bump aioasuswrt to 1.5.3 changelog

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link

home-assistant bot commented Dec 12, 2025

Hey there @ollo69, @Vaskivskyi, mind taking a look at this pull request as it has been labeled with an integration (asuswrt) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of asuswrt can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign asuswrt Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@kennedyshead kennedyshead mentioned this pull request Dec 12, 2025
Closed
@joostlek joostlek added this to the 2025.12.4 milestone Dec 13, 2025
@joostlek joostlek merged commit 13f3b49 into home-assistant:dev Dec 13, 2025
67 checks passed
@upsuper
Copy link
Contributor

upsuper commented Dec 13, 2025 •
edited
Loading

The fix here is kennedyshead/aioasuswrt@c2a108c but it seems to be just covering up the actual issue.

I believe the issue was introduced in kennedyshead/aioasuswrt@0a980ee where

regex = rf"^{item}=([\w.\-/: <>]+)"

was replaced with

_NVRAM_REGEX = r"^{<item>}=([\w.\-/: <>]+)"
# ...
regex = _NVRAM_REGEX.format(item)

But {<item>} doesn't seem to be a valid syntax that Python's str.format supports, at least I'm not seeing it in the documentation. So I would imagine the result here being the try: block just fails all the times and leaving a lot of info logging saying Cant format X.

I think this code should be either

_NVRAM_REGEX = r"^{}=([\w.\-/: <>]+)"
regex = _NVRAM_REGEX.format(item)

or

_NVRAM_REGEX = r"^{item}=([\w.\-/: <>]+)"
regex = _NVRAM_REGEX.format(item=item)

@upsuper upsuper mentioned this pull request Dec 13, 2025
Merged
@upsuper
Copy link
Contributor

upsuper commented Dec 13, 2025

Raising a PR for aioasuswrt in kennedyshead/aioasuswrt#111

@kennedyshead
Copy link
Contributor Author

kennedyshead commented Dec 14, 2025 

_NVRAM_REGEX = r"^{item}=([\w.\-/: <>]+)"
regex = _NVRAM_REGEX.format(item=item)

Yes you are correct, but as this is solved in 2.0.y I wont dig more into this in 1.5.y. At least now it wont fail.

@kennedyshead kennedyshead deleted the aioasuswrt-1.5.3 branch December 14, 2025 10:49
@TheJulianJES TheJulianJES mentioned this pull request Dec 15, 2025
Merged
21 tasks
@github-actions github-actions bot locked and limited conversation to collaborators Dec 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@joostlek joostlek joostlek approved these changes

Assignees

No one assigned

Labels

bugfix by-code-owner cherry-picked cla-signed dependency integration: asuswrt Quality Scale: No score small-pr PRs with less than 30 lines.

Projects

None yet

Milestone

2025.12.4

Development

Successfully merging this pull request may close these issues.

[asuswrt] 2025.12.3 Failed to set up: KeyError (aioasuswrt)

4 participants

@kennedyshead @upsuper @joostlek @bramkragten