Skip to content

Enable volvo engine status for all engine types #158437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zweckj merged 1 commit into from
Dec 9, 2025
+106 −4
Merged

Enable volvo engine status for all engine types #158437

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions homeassistant/components/volvo/coordinator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -297,9 +297,9 @@ def __init__(
async def _async_determine_api_calls(
self,
) -> list[Callable[[], Coroutine[Any, Any, Any]]]:
api_calls: list[Any] = []
api = self.context.api
vehicle = self.context.vehicle
api_calls: list[Any] = [api.async_get_engine_status]

if vehicle.has_battery_engine():
capabilities = await api.async_get_energy_capabilities()
Expand All @@ -317,9 +317,6 @@ def _normalize_key(key: str) -> str:

api_calls.append(self._async_get_energy_state)

if vehicle.has_combustion_engine():
api_calls.append(api.async_get_engine_status)

return api_calls

async def _async_get_energy_state(
Expand Down
98 changes: 98 additions & 0 deletions tests/components/volvo/snapshots/test_binary_sensor.ambr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -538,6 +538,55 @@
'state': 'off',
})
# ---
# name: test_binary_sensor[ex30_2024][binary_sensor.volvo_ex30_engine_status-entry]
EntityRegistryEntrySnapshot({
'aliases': set({
}),
'area_id': None,
'capabilities': None,
'config_entry_id': <ANY>,
'config_subentry_id': <ANY>,
'device_class': None,
'device_id': <ANY>,
'disabled_by': None,
'domain': 'binary_sensor',
'entity_category': None,
'entity_id': 'binary_sensor.volvo_ex30_engine_status',
'has_entity_name': True,
'hidden_by': None,
'icon': None,
'id': <ANY>,
'labels': set({
}),
'name': None,
'options': dict({
}),
'original_device_class': <BinarySensorDeviceClass.RUNNING: 'running'>,
'original_icon': None,
'original_name': 'Engine status',
'platform': 'volvo',
'previous_unique_id': None,
'suggested_object_id': None,
'supported_features': 0,
'translation_key': 'engine_status',
'unique_id': 'yv1abcdefg1234567_engine_status',
'unit_of_measurement': None,
})
# ---
# name: test_binary_sensor[ex30_2024][binary_sensor.volvo_ex30_engine_status-state]
StateSnapshot({
'attributes': ReadOnlyDict({
'device_class': 'running',
'friendly_name': 'Volvo EX30 Engine status',
}),
'context': <ANY>,
'entity_id': 'binary_sensor.volvo_ex30_engine_status',
'last_changed': <ANY>,
'last_reported': <ANY>,
'last_updated': <ANY>,
'state': 'off',
})
# ---
# name: test_binary_sensor[ex30_2024][binary_sensor.volvo_ex30_fog_light_front-entry]
EntityRegistryEntrySnapshot({
'aliases': set({
Expand Down Expand Up @@ -4801,6 +4850,55 @@
'state': 'off',
})
# ---
# name: test_binary_sensor[xc40_electric_2024][binary_sensor.volvo_xc40_engine_status-entry]
EntityRegistryEntrySnapshot({
'aliases': set({
}),
'area_id': None,
'capabilities': None,
'config_entry_id': <ANY>,
'config_subentry_id': <ANY>,
'device_class': None,
'device_id': <ANY>,
'disabled_by': None,
'domain': 'binary_sensor',
'entity_category': None,
'entity_id': 'binary_sensor.volvo_xc40_engine_status',
'has_entity_name': True,
'hidden_by': None,
'icon': None,
'id': <ANY>,
'labels': set({
}),
'name': None,
'options': dict({
}),
'original_device_class': <BinarySensorDeviceClass.RUNNING: 'running'>,
'original_icon': None,
'original_name': 'Engine status',
'platform': 'volvo',
'previous_unique_id': None,
'suggested_object_id': None,
'supported_features': 0,
'translation_key': 'engine_status',
'unique_id': 'yv1abcdefg1234567_engine_status',
'unit_of_measurement': None,
})
# ---
# name: test_binary_sensor[xc40_electric_2024][binary_sensor.volvo_xc40_engine_status-state]
StateSnapshot({
'attributes': ReadOnlyDict({
'device_class': 'running',
'friendly_name': 'Volvo XC40 Engine status',
}),
'context': <ANY>,
'entity_id': 'binary_sensor.volvo_xc40_engine_status',
'last_changed': <ANY>,
'last_reported': <ANY>,
'last_updated': <ANY>,
'state': 'off',
})
# ---
# name: test_binary_sensor[xc40_electric_2024][binary_sensor.volvo_xc40_fog_light_front-entry]
EntityRegistryEntrySnapshot({
'aliases': set({
Expand Down
7 changes: 7 additions & 0 deletions tests/components/volvo/snapshots/test_diagnostics.ambr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,6 +167,13 @@
'unit': 'mi',
'value': 150,
}),
'engineStatus': dict({
'extra_data': dict({
}),
'timestamp': '2024-12-30T15:00:00+00:00',
'unit': None,
'value': 'STOPPED',
}),
'estimatedChargingTimeToTargetBatteryChargeLevel': dict({
'extra_data': dict({
'updated_at': '2025-07-02T08:51:23Z',
Expand Down
Loading