Skip to content

Conversation

@Thomas55555
Copy link
Contributor

@Thomas55555 Thomas55555 commented Nov 25, 2025

Proposed change

Fix wrong string. Needs: #157337
Please include in next beta

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@Thomas55555 Thomas55555 marked this pull request as ready for review November 26, 2025 15:40
@NoRi2909
Copy link
Contributor

Could you include fixes regarding my post-merge comments from #145237 ?

These two do not match:

      "high_air_quality": "High air pollution",
      "very_high_air_quality": "Very High air pollution",

At least the "High" in the second should be sentence-cased.

@joostlek joostlek marked this pull request as draft November 27, 2025 10:39
@Thomas55555
Copy link
Contributor Author

Could you include fixes regarding my post-merge comments from #145237 ?

These two do not match:

      "high_air_quality": "High air pollution",
      "very_high_air_quality": "Very High air pollution",

At least the "High" in the second should be sentence-cased.

This PR is actually to fix your comments. The two above are deleted in this PR, because it turned out they are not needed.
Or did I miss anything?

Copy link
Contributor

@NoRi2909 NoRi2909 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I was looking for a change of these two strings and completely overlooked the deletion. 👀

Thank you very much!

@Thomas55555 Thomas55555 marked this pull request as ready for review November 27, 2025 12:18
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @Thomas55555 👍

../Frenck

                       

Blogging my personal ramblings at frenck.dev

@frenck frenck added this to the 2025.12.0 milestone Nov 27, 2025
@frenck frenck merged commit 4f6624d into home-assistant:dev Nov 27, 2025
36 checks passed
@Thomas55555 Thomas55555 deleted the strings_air_quality branch November 27, 2025 18:50
@github-actions github-actions bot locked and limited conversation to collaborators Nov 28, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants