Skip to content

Conversation

@hanwg
Copy link
Contributor

@hanwg hanwg commented Nov 24, 2025

Proposed change

Sending a message to a group notify entity without the title parameter fails with a string value is None for dictionary value @ data['title'] error.

This PR fixes the issue by checking the title parameter is present and supported before passing the value to the service.

How to reproduce the bug:

  1. Go to Settings > Devices & services > Helpers > Create helper
  2. In the "Create helper" dialog, click on Group then Notify group
  3. Enter group In the Name field, then select 1 or more notify entities in the Members field then click Submit.
  4. The notify.group entity is created.
  5. Run the following action:
action: notify.send_message
data:
  message: test
target:
  entity_id: notify.group
  1. The following error is observed: Failed to perform the action notify.send_message. string value is None for dictionary value @ data['title']. Got None (Expected result: message is sent to all members in the group)

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration (group) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of group can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign group Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@hanwg hanwg marked this pull request as ready for review November 24, 2025 14:12
@hanwg hanwg requested a review from a team as a code owner November 24, 2025 14:12
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft November 24, 2025 19:06
@hanwg hanwg marked this pull request as ready for review November 25, 2025 09:32
@MartinHjelmare MartinHjelmare marked this pull request as draft November 28, 2025 09:51
@hanwg hanwg marked this pull request as ready for review November 29, 2025 02:09
@home-assistant home-assistant bot marked this pull request as draft December 1, 2025 08:21
@hanwg hanwg marked this pull request as ready for review December 2, 2025 02:19
Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@MartinHjelmare MartinHjelmare added this to the 2025.12.0 milestone Dec 3, 2025
@MartinHjelmare MartinHjelmare merged commit 0a08326 into home-assistant:dev Dec 3, 2025
66 checks passed
frenck pushed a commit that referenced this pull request Dec 3, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Dec 4, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants