-
-
Notifications
You must be signed in to change notification settings - Fork 36.2k
Fix bug in group notify entities when title is missing #157171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Co-authored-by: Martin Hjelmare <[email protected]>
MartinHjelmare
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great!
Co-authored-by: Martin Hjelmare <[email protected]>
Proposed change
Sending a message to a group notify entity without the
titleparameter fails with astring value is None for dictionary value @ data['title']error.This PR fixes the issue by checking the
titleparameter is present and supported before passing the value to the service.How to reproduce the bug:
groupIn the Name field, then select 1 or more notify entities in the Members field then click Submit.notify.groupentity is created.Failed to perform the action notify.send_message. string value is None for dictionary value @ data['title']. Got None(Expected result: message is sent to all members in the group)Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: