Mark nordpool as service integration_type #157810
Conversation
|
Hey there @gjohansson-ST, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
There was a problem hiding this comment.
Pull request overview
This PR correctly reclassifies the Nord Pool integration from hub to service integration type. The change is justified because Nord Pool provides cloud-based electricity pricing data and does not represent a physical hub device. This classification aligns with the Home Assistant device database and the integration's existing code, which already uses DeviceEntryType.SERVICE in the entity definition.
Key Changes
- Updated
integration_typefrom "hub" to "service" in manifest.json - Updated the generated integrations.json file to reflect the manifest change
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| homeassistant/components/nordpool/manifest.json | Changed integration_type from "hub" to "service" to reflect that this is a cloud service rather than a physical device |
| homeassistant/generated/integrations.json | Updated generated file with the same integration_type change for consistency |
Breaking change
Proposed change
In light of the device database, I think that nordpool should be a
serviceinstead of ahub, as it exposes no physical devices and only represents a cloud service.Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: